third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 2922803003: Move most scripting-related methods from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2922803003: Move most scripting-related methods from WebFrame to WebLocalFrame. (Closed)

Patch Set: Rebasing... Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index 0d012e0cb6a55bcd2bfab6d1dcf2b425580d0435..685aaba5c7bf5394667134ad6973ca5e57da845c 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -3809,7 +3809,7 @@ TEST_P(WebViewTest, StopLoadingIfJavaScriptURLReturnsNoStringResult) {

FrameTestHelpers::WebViewHelper main_web_view;

main_web_view.InitializeAndLoad("about:blank", true, 0, &client);

- WebFrame* frame = main_web_view.WebView()->MainFrame();

+ WebLocalFrame* frame = main_web_view.WebView()->MainFrameImpl();

v8::HandleScope scope(v8::Isolate::GetCurrent());

v8::Local<v8::Value> v8_value =

frame->ExecuteScriptAndReturnValue(WebScriptSource(