Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2922443002: [Web apks] Stop setting channels on web apk notifications (Closed)

Created:
3 years, 6 months ago by awdf
Modified:
3 years, 6 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Web apks] Stop setting channels on web apk notifications - This fixes a crash when web apk notifications are displayed on recent builds of Android O. - The crash occurred because the channel we were setting on web apk notifications was never created for the web apk - it was only created for the browser apk - while the notifications were posted by the web apk. - This fixes things by not setting a channel on web apk notifications. Web apks do not target O yet so this is fine for now. When they do, web apks will need their own channel(s). R=peter@chromium.org Bug: 727178,726340 Change-Id: I4d200f1dc63c484c8728f0b21d993ef35b0cf90c Reviewed-on: https://chromium-review.googlesource.com/519345 Reviewed-by: Yaron Friedman <yfriedman@chromium.org>; Reviewed-by: Peter Beverloo <peter@chromium.org>; Commit-Queue: Anita Woodruff <awdf@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#475949} Review-Url: https://codereview.chromium.org/2922443002 . Cr-Commit-Position: refs/branch-heads/3112@{#83} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/2fb2815a0c9b277427231ce47b9bc232f5ba65c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -62 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderForO.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java View 3 chunks +14 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilderTest.java View 9 chunks +45 lines, -37 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationBuilderBaseTest.java View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java View 6 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Peter Beverloo
lgtm
3 years, 6 months ago (2017-06-01 11:09:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922443002/1
3 years, 6 months ago (2017-06-01 11:35:33 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 6 months ago (2017-06-01 11:35:36 UTC) #7
awdf
3 years, 6 months ago (2017-06-01 11:38:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2fb2815a0c9b277427231ce47b9bc232f5ba65c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698