Chromium Code Reviews
Description[Web apks] Stop setting channels on web apk notifications
- This fixes a crash when web apk notifications are displayed on
recent builds of Android O.
- The crash occurred because the channel we were setting on web apk
notifications was never created for the web apk - it was only
created for the browser apk - while the notifications were posted by
the web apk.
- This fixes things by not setting a channel on web apk notifications.
Web apks do not target O yet so this is fine for now. When they do,
web apks will need their own channel(s).
R=peter@chromium.org
Bug: 727178,726340
Change-Id: I4d200f1dc63c484c8728f0b21d993ef35b0cf90c
Reviewed-on: https://chromium-review.googlesource.com/519345
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#475949}
Review-Url: https://codereview.chromium.org/2922443002 .
Cr-Commit-Position: refs/branch-heads/3112@{#83}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed: https://chromium.googlesource.com/chromium/src/+/2fb2815a0c9b277427231ce47b9bc232f5ba65c6
Patch Set 1 #Messages
Total messages: 9 (5 generated)
|