Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2559)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

Issue 2922443002: [Web apks] Stop setting channels on web apk notifications (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
index a1f62659779c1fd1e66f34247ff6f7ed1c3669e1..9224d4db4f52b83d58aece4fd84b7e16411034e8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
@@ -79,8 +79,9 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {
private final Context mContext;
- public CustomNotificationBuilder(Context context) {
- super(context.getResources());
+ public CustomNotificationBuilder(
+ Context context, @ChannelDefinitions.ChannelId String channelId) {
+ super(context.getResources(), channelId);
mContext = context;
}
@@ -142,7 +143,7 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {
// TODO(crbug.com/697104) We should probably use a Compat builder.
ChromeNotificationBuilder builder =
NotificationBuilderFactory.createChromeNotificationBuilder(
- false /* preferCompat */, ChannelDefinitions.CHANNEL_ID_SITES);
+ false /* preferCompat */, mChannelId);
builder.setTicker(mTickerText);
builder.setContentIntent(mContentIntent);
builder.setDeleteIntent(mDeleteIntent);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698