chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java - Issue 2922443002: [Web apks] Stop setting channels on web apk notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

Issue 2922443002: [Web apks] Stop setting channels on web apk notifications (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

index 06b8dbbbf048c4743e541d7051b0a272d2c2b12c..b4f041da0c6a47470c88ea979a55719bc3b26427 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

@@ -90,7 +90,7 @@ public class NotificationUmaTracker {

recordHistogram("Mobile.SystemNotification.Blocked", type);

return;

}

- if (BuildInfo.isAtLeastO() && isChannelBlocked(channelId)) {

+ if (BuildInfo.isAtLeastO() && channelId != null && isChannelBlocked(channelId)) {

recordHistogram("Mobile.SystemNotification.ChannelBlocked", type);

return;

}