chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java - Issue 2922443002: [Web apks] Stop setting channels on web apk notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java

Issue 2922443002: [Web apks] Stop setting channels on web apk notifications (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderForO.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java

index 16fa66e7d17e0effe0777cb3a3276b7a4258a061..4f5587b9abc0883ecaa010a55990312b6f374867 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java

@@ -108,6 +108,8 @@ public abstract class NotificationBuilderBase {

private final int mLargeIconHeightPx;

private final RoundedIconGenerator mIconGenerator;

+ protected final String mChannelId;

protected CharSequence mTitle;

protected CharSequence mBody;

protected CharSequence mOrigin;

@@ -126,12 +128,14 @@ public abstract class NotificationBuilderBase {

private Bitmap mLargeIcon;

- public NotificationBuilderBase(Resources resources) {

+ public NotificationBuilderBase(

+ Resources resources, @ChannelDefinitions.ChannelId String channelId) {

mLargeIconWidthPx =

resources.getDimensionPixelSize(android.R.dimen.notification_large_icon_width);

mLargeIconHeightPx =

resources.getDimensionPixelSize(android.R.dimen.notification_large_icon_height);

mIconGenerator = createIconGenerator(resources);

+ mChannelId = channelId;

}

/**