Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 2921393002: Move --eventlog-endpoint out of isolateFlags. (Closed)

Created:
3 years, 6 months ago by mcgreevy
Modified:
3 years, 6 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Move --eventlog-endpoint out of isolateFlags. The batcharchive subcommand instantiates multiple isolateFlag structs per invocation. We want only a single eventlog endpoint per invocation. So, this CL moves the eventlog-endpoint flag out of isolateFlags, into its own struct that can be used directly from the batchArchiveRun, expArchiveRun and ArchiveRun structs. BUG=727985 Review-Url: https://codereview.chromium.org/2921393002 Committed: https://github.com/luci/luci-go/commit/98bc6697c7d6ffb6dd445180d5cd0d8426aab28d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M client/cmd/isolate/archive.go View 3 chunks +3 lines, -1 line 0 comments Download
M client/cmd/isolate/common.go View 3 chunks +9 lines, -3 lines 0 comments Download
M client/cmd/isolate/exp_archive.go View 3 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
mcgreevy
3 years, 6 months ago (2017-06-06 03:52:12 UTC) #2
mithro
lgtm
3 years, 6 months ago (2017-06-06 06:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921393002/1
3 years, 6 months ago (2017-06-06 06:49:45 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 06:55:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/98bc6697c7d6ffb6dd445180d5cd0d8426aab28d

Powered by Google App Engine
This is Rietveld 408576698