Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: client/cmd/isolate/common.go

Issue 2921393002: Move --eventlog-endpoint out of isolateFlags. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/cmd/isolate/archive.go ('k') | client/cmd/isolate/exp_archive.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/cmd/isolate/common.go
diff --git a/client/cmd/isolate/common.go b/client/cmd/isolate/common.go
index 5137f8047714ec2354102eba2cf995bfae5ceb07..ba0da5b712177523bea62a8b9bfa0ef0a3b8b802 100644
--- a/client/cmd/isolate/common.go
+++ b/client/cmd/isolate/common.go
@@ -71,7 +71,6 @@ func (c *commonServerFlags) createAuthClient() (*http.Client, error) {
type isolateFlags struct {
// TODO(tandrii): move ArchiveOptions from isolate pkg to here.
isolate.ArchiveOptions
- EventlogEndpoint string
}
func (c *isolateFlags) Init(f *flag.FlagSet) {
@@ -84,8 +83,6 @@ func (c *isolateFlags) Init(f *flag.FlagSet) {
f.Var(&c.ConfigVariables, "config-variable", "Config variables are used to determine which conditions should be matched when loading a .isolate file, default: [].")
f.Var(&c.PathVariables, "path-variable", "Path variables are used to replace file paths when loading a .isolate file, default: {}")
f.Var(&c.ExtraVariables, "extra-variable", "Extraneous variables are replaced on the command entry and on paths in the .isolate file but are not considered relative paths.")
-
- f.StringVar(&c.EventlogEndpoint, "eventlog-endpoint", "", `The URL destination for eventlogs. The special values "prod" or "test" may be used to target the standard prod or test urls repspectively. An empty string disables eventlogging.`)
}
// RequiredIsolateFlags specifies which flags are required on the command line
@@ -132,3 +129,12 @@ func (c *isolateFlags) Parse(cwd string, flags RequiredIsolateFlags) error {
}
return nil
}
+
+// loggingFlags configures eventlog logging.
+type loggingFlags struct {
+ EventlogEndpoint string
+}
+
+func (lf *loggingFlags) Init(f *flag.FlagSet) {
+ f.StringVar(&lf.EventlogEndpoint, "eventlog-endpoint", "", `The URL destination for eventlogs. The special values "prod" or "test" may be used to target the standard prod or test urls repspectively. An empty string disables eventlogging.`)
+}
« no previous file with comments | « client/cmd/isolate/archive.go ('k') | client/cmd/isolate/exp_archive.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698