Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9583)

Unified Diff: client/cmd/isolate/archive.go

Issue 2921393002: Move --eventlog-endpoint out of isolateFlags. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/cmd/isolate/common.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/cmd/isolate/archive.go
diff --git a/client/cmd/isolate/archive.go b/client/cmd/isolate/archive.go
index 99ed9e3dca600977321e890cfe22d70a8ceb0e2e..5260bc5b1ef2cdab75b41af113dabec7c390c9fc 100644
--- a/client/cmd/isolate/archive.go
+++ b/client/cmd/isolate/archive.go
@@ -33,6 +33,7 @@ func cmdArchive(defaultAuthOpts auth.Options) *subcommands.Command {
c := archiveRun{}
c.commonServerFlags.Init(defaultAuthOpts)
c.isolateFlags.Init(&c.Flags)
+ c.loggingFlags.Init(&c.Flags)
return &c
},
}
@@ -41,6 +42,7 @@ func cmdArchive(defaultAuthOpts auth.Options) *subcommands.Command {
type archiveRun struct {
commonServerFlags
isolateFlags
+ loggingFlags loggingFlags
}
func (c *archiveRun) Parse(a subcommands.Application, args []string) error {
@@ -103,7 +105,7 @@ func (c *archiveRun) main(a subcommands.Application, args []string) error {
if item.Error() != nil {
archiveDetails.IsolateHash = []string{string(item.Digest())}
}
- eventlogger := NewLogger(ctx, c.isolateFlags.EventlogEndpoint)
+ eventlogger := NewLogger(ctx, c.loggingFlags.EventlogEndpoint)
op := logpb.IsolateClientEvent_LEGACY_ARCHIVE.Enum()
if err := eventlogger.logStats(ctx, op, start, end, archiveDetails); err != nil {
log.Printf("Failed to log to eventlog: %v", err)
« no previous file with comments | « no previous file | client/cmd/isolate/common.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698