Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: client/cmd/isolate/exp_archive.go

Issue 2921393002: Move --eventlog-endpoint out of isolateFlags. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/cmd/isolate/common.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/cmd/isolate/exp_archive.go
diff --git a/client/cmd/isolate/exp_archive.go b/client/cmd/isolate/exp_archive.go
index eae05aefbb6183b46c6788aae5aed740d1b0af5e..d78eb53821d3854fcd24ba3346fa8aacab2f8db4 100644
--- a/client/cmd/isolate/exp_archive.go
+++ b/client/cmd/isolate/exp_archive.go
@@ -50,6 +50,7 @@ func cmdExpArchive(defaultAuthOpts auth.Options) *subcommands.Command {
c := &expArchiveRun{}
c.commonServerFlags.Init(defaultAuthOpts)
c.isolateFlags.Init(&c.Flags)
+ c.loggingFlags.Init(&c.Flags)
c.Flags.StringVar(&c.dumpJSON, "dump-json", "",
"Write isolated digests of archived trees to this file as JSON")
return c
@@ -62,6 +63,7 @@ func cmdExpArchive(defaultAuthOpts auth.Options) *subcommands.Command {
type expArchiveRun struct {
commonServerFlags // Provides the GetFlags method.
isolateFlags isolateFlags
+ loggingFlags loggingFlags
dumpJSON string
}
@@ -286,7 +288,7 @@ func (c *expArchiveRun) main() error {
MissBytes: &checker.Miss.Bytes,
IsolateHash: []string{string(isolItem.Digest)},
}
- eventlogger := NewLogger(ctx, c.isolateFlags.EventlogEndpoint)
+ eventlogger := NewLogger(ctx, c.loggingFlags.EventlogEndpoint)
op := logpb.IsolateClientEvent_ARCHIVE.Enum()
if err := eventlogger.logStats(ctx, op, start, end, archiveDetails); err != nil {
log.Printf("Failed to log to eventlog: %v", err)
« no previous file with comments | « client/cmd/isolate/common.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698