Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2921263002: Remove many delegates, let's see what breaks

Created:
3 years, 6 months ago by Miguel Garcia
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, awdf+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, jam, darin-cc_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove many delegates, let's see what breaks BUG=

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : Working #

Patch Set 4 : fixed layout #

Patch Set 5 : Extension support #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : compile #

Patch Set 9 : compile #

Patch Set 10 : compile #

Patch Set 11 : compile #

Patch Set 12 : rebase #

Patch Set 13 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -298 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/notifications/extension_notification_handler.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/notifications/extension_notification_handler.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +42 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.cc View 1 2 3 4 5 6 7 5 chunks +4 lines, -175 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_apitest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/notifications/native_notification_delegate.h View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/notifications/native_notification_delegate.cc View 1 2 3 4 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/notifications/non_persistent_notification_handler.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/notifications/non_persistent_notification_handler.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_common.h View 1 2 3 4 5 6 7 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_common.cc View 1 2 3 4 5 6 7 3 chunks +60 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_delegate.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_display_service.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_display_service.cc View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_handler.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/notifications/persistent_notification_handler.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/notifications/persistent_notification_handler.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/notifications/stub_notification_display_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/stub_notification_display_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/notifications/web_notification_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/web_notification_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +6 lines, -58 lines 0 comments Download
M chrome/tools/build/mac/verify_order View 1 chunk +1 line, -1 line 0 comments Download
M content/test/mock_platform_notification_service.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 54 (48 generated)
Miguel Garcia
fixes
3 years, 6 months ago (2017-06-05 11:00:58 UTC) #5
Miguel Garcia
fixed layout
3 years, 6 months ago (2017-06-06 09:59:09 UTC) #14
Miguel Garcia
Extension support
3 years, 6 months ago (2017-06-08 14:26:49 UTC) #19
Miguel Garcia
rebase
3 years, 6 months ago (2017-06-08 15:20:36 UTC) #24
Miguel Garcia
compile
3 years, 6 months ago (2017-06-09 10:58:11 UTC) #33
Miguel Garcia
3 years, 6 months ago (2017-06-09 11:23:41 UTC) #38
compile

Powered by Google App Engine
This is Rietveld 408576698