chrome/browser/notifications/stub_notification_display_service.h - Issue 2921263002: Remove many delegates, let's see what breaks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/notifications/stub_notification_display_service.h

Issue 2921263002: Remove many delegates, let's see what breaks

Patch Set: fix test Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/notifications/platform_notification_service_unittest.cc ('k') | chrome/browser/notifications/stub_notification_display_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_NOTIFICATIONS_STUB_NOTIFICATION_DISPLAY_SERVICE_H_	5 #ifndef CHROME_BROWSER_NOTIFICATIONS_STUB_NOTIFICATION_DISPLAY_SERVICE_H_

6 #define CHROME_BROWSER_NOTIFICATIONS_STUB_NOTIFICATION_DISPLAY_SERVICE_H_	6 #define CHROME_BROWSER_NOTIFICATIONS_STUB_NOTIFICATION_DISPLAY_SERVICE_H_

7	7

8 #include <memory>	8 #include <memory>

9 #include <utility>	9 #include <utility>

10 #include <vector>	10 #include <vector>

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 const Notification& notification) override;	44 const Notification& notification) override;

45 void Close(NotificationCommon::Type notification_type,	45 void Close(NotificationCommon::Type notification_type,

46 const std::string& notification_id) override;	46 const std::string& notification_id) override;

47 void GetDisplayed(const DisplayedNotificationsCallback& callback) override;	47 void GetDisplayed(const DisplayedNotificationsCallback& callback) override;

48	48

49 private:	49 private:

50 // Data to store for a notification that's being shown through this service.	50 // Data to store for a notification that's being shown through this service.

51 using NotificationData = std::pair<NotificationCommon::Type, Notification>;	51 using NotificationData = std::pair<NotificationCommon::Type, Notification>;

52	52

53 std::vector<NotificationData> notifications_;	53 std::vector<NotificationData> notifications_;

	54 Profile* profile_;

54	55

55 DISALLOW_COPY_AND_ASSIGN(StubNotificationDisplayService);	56 DISALLOW_COPY_AND_ASSIGN(StubNotificationDisplayService);

56 };	57 };

57	58

58 #endif // CHROME_BROWSER_NOTIFICATIONS_STUB_NOTIFICATION_DISPLAY_SERVICE_H_	59 #endif // CHROME_BROWSER_NOTIFICATIONS_STUB_NOTIFICATION_DISPLAY_SERVICE_H_

OLD	NEW