chrome/browser/notifications/non_persistent_notification_handler.cc - Issue 2921263002: Remove many delegates, let's see what breaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/non_persistent_notification_handler.cc

Issue 2921263002: Remove many delegates, let's see what breaks

Patch Set: fix test Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/non_persistent_notification_handler.h ('k') | chrome/browser/notifications/notification_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/non_persistent_notification_handler.cc

diff --git a/chrome/browser/notifications/non_persistent_notification_handler.cc b/chrome/browser/notifications/non_persistent_notification_handler.cc

index 7211d461fc1474bf5383902a1bf6fd1c1aa2270a..9b913adad265f72d8451acb85ff0e9336fa558c1 100644

--- a/chrome/browser/notifications/non_persistent_notification_handler.cc

+++ b/chrome/browser/notifications/non_persistent_notification_handler.cc

@@ -46,3 +46,9 @@ void NonPersistentNotificationHandler::OnClick(

void NonPersistentNotificationHandler::OpenSettings(Profile* profile) {

NotificationCommon::OpenNotificationSettings(profile);

}

+bool NonPersistentNotificationHandler::ShouldDisplayOnFullScreen(

+ Profile* profile,

+ const std::string& origin) const {

+ return NotificationCommon::ActiveTabIsFullScreen(profile, GURL(origin));