Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: chrome/browser/extensions/api/notifications/extension_notification_handler.h

Issue 2921263002: Remove many delegates, let's see what breaks
Patch Set: fix test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notifications/extension_notification_handler.h
diff --git a/chrome/browser/extensions/api/notifications/extension_notification_handler.h b/chrome/browser/extensions/api/notifications/extension_notification_handler.h
index ba098bd9773571eee6aa6a7323534fc609588900..3a7cd710c7107231f62ad14053955a4081d8d24a 100644
--- a/chrome/browser/extensions/api/notifications/extension_notification_handler.h
+++ b/chrome/browser/extensions/api/notifications/extension_notification_handler.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDLER_H_
#define CHROME_BROWSER_EXTENSIONS_API_NOTIFICATIONS_EXTENSION_NOTIFICATION_HANDLER_H_
+#include "base/feature_list.h"
#include "base/macros.h"
#include "chrome/browser/notifications/notification_handler.h"
#include "extensions/browser/event_router.h"
@@ -13,6 +14,10 @@ class Profile;
namespace extensions {
+// Exposed publicly for tests.
+// TODO(miguelg) we can probably get rid of this now.
+extern const base::Feature kAllowFullscreenAppNotificationsFeature;
+
// Handler for notifications shown by extensions. Will be created and owned by
// the NativeNotificationDisplayService.
class ExtensionNotificationHandler : public NotificationHandler {
@@ -32,6 +37,8 @@ class ExtensionNotificationHandler : public NotificationHandler {
int action_index,
const base::NullableString16& reply) override;
void OpenSettings(Profile* profile) override;
+ bool ShouldDisplayOnFullScreen(Profile* profile,
+ const std::string& origin) const override;
protected:
// Overriden in unit tests.
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/extensions/api/notifications/extension_notification_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698