Do not rewrite about urls to chrome:// for cetain renderer-initated loads

Do not rewrite about urls to chrome://  for cetain renderer-initated loads

This fixes the bug where about:newtab gets rewritten to chrome://newtab
and it corrupts omnibox UI. Chrome layer expects that chrome://newtab
will be NTP, but about:newtab can be loaded as a regular web page as
proven in crbug.com/687863 POS.

This CL also enables testWindowOpenWithAboutNewTabScript, adds tests
for URLRewriting and allows |currentURLWithTrustLevel:| to return all kinds 
of about:// urls (old workaround was put in place for UIWebView which used
JS overrides for window.open).

BUG=687863
Review-Url: https://codereview.chromium.org/2918013002
Cr-Commit-Position: refs/heads/master@{#476716}
Committed: https://chromium.googlesource.com/chromium/src/+/657495c5b5591a13ca826a373ada0c0038d79b61

[Eugene But (OOO till 7-30), 2017-06-02 00:25:26]

Description was changed from

==========
Do not rewrite about urls to chrome://  for cetain renderer-initated loads

This fixes the bug where about:newtab gets rewritten to chrome://newtab
and it corrupts omnibox UI. Chrome layer expects that chrome://newtab
will be NTP, but about:newtab can be loaded as a regular web page as
proven in crbug.com/687863 POS.

BUG=687863
==========

to

==========
Do not rewrite about urls to chrome://  for cetain renderer-initated loads

This fixes the bug where about:newtab gets rewritten to chrome://newtab
and it corrupts omnibox UI. Chrome layer expects that chrome://newtab
will be NTP, but about:newtab can be loaded as a regular web page as
proven in crbug.com/687863 POS.

This CL also enables testWindowOpenWithAboutNewTabScript, adds tests
for URLRewriting and allows |currentURLWithTrustLevel:| to return all kinds 
of about:// urls (old workaround was put in place for UIWebView which used
JS overrides for window.open).

BUG=687863
==========

[Eugene But (OOO till 7-30), 2017-06-02 00:27:33]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 00:28:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 01:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 01:20:51]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-06-02 04:24:24]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[Eugene But (OOO till 7-30), 2017-06-02 04:24:25]

PTAL

[kkhorimoto, 2017-06-02 17:12:57]

lgtm!

[Eugene But (OOO till 7-30), 2017-06-02 17:40:54]

Thanks for a quick review!

[Eugene But (OOO till 7-30), 2017-06-02 17:40:57]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:41:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 18:00:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496425257813410,
"parent_rev": "9e1360800f1a300b33c76208ea7448321600fbb0", "commit_rev":
"657495c5b5591a13ca826a373ada0c0038d79b61"}

[commit-bot: I haz the power, 2017-06-02 18:00:56]

Description was changed from

==========
Do not rewrite about urls to chrome://  for cetain renderer-initated loads

This fixes the bug where about:newtab gets rewritten to chrome://newtab
and it corrupts omnibox UI. Chrome layer expects that chrome://newtab
will be NTP, but about:newtab can be loaded as a regular web page as
proven in crbug.com/687863 POS.

This CL also enables testWindowOpenWithAboutNewTabScript, adds tests
for URLRewriting and allows |currentURLWithTrustLevel:| to return all kinds 
of about:// urls (old workaround was put in place for UIWebView which used
JS overrides for window.open).

BUG=687863
==========

to

==========
Do not rewrite about urls to chrome://  for cetain renderer-initated loads

This fixes the bug where about:newtab gets rewritten to chrome://newtab
and it corrupts omnibox UI. Chrome layer expects that chrome://newtab
will be NTP, but about:newtab can be loaded as a regular web page as
proven in crbug.com/687863 POS.

This CL also enables testWindowOpenWithAboutNewTabScript, adds tests
for URLRewriting and allows |currentURLWithTrustLevel:| to return all kinds 
of about:// urls (old workaround was put in place for UIWebView which used
JS overrides for window.open).

BUG=687863

Review-Url: https://codereview.chromium.org/2918013002
Cr-Commit-Position: refs/heads/master@{#476716}
Committed:
https://chromium.googlesource.com/chromium/src/+/657495c5b5591a13ca826a373ada...
==========

[commit-bot: I haz the power, 2017-06-02 18:00:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/657495c5b5591a13ca826a373ada...