Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: ios/chrome/browser/web/window_open_by_dom_egtest.mm

Issue 2918013002: Do not rewrite about urls to chrome:// for cetain renderer-initated loads (Closed)
Patch Set: Self review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web/window_open_by_dom_egtest.mm
diff --git a/ios/chrome/browser/web/window_open_by_dom_egtest.mm b/ios/chrome/browser/web/window_open_by_dom_egtest.mm
index 631be43519c5907f3feaaa69e71f93c06530ff31..fbfe60f2b2323bfc7548f35ba4b82107a5716de9 100644
--- a/ios/chrome/browser/web/window_open_by_dom_egtest.mm
+++ b/ios/chrome/browser/web/window_open_by_dom_egtest.mm
@@ -203,8 +203,7 @@ NSString* GetBlockedPopupInfobarText(size_t blocked_count) {
// Tests opening a child window using the following link
// <a href="data:text/html,<script>window.location='about:newtab';</script>"
// target="_blank">
-// TODO(crbug.com/687863): Enable this test.
-- (void)DISABLED_testWindowOpenWithAboutNewTabScript {
+- (void)testWindowOpenWithAboutNewTabScript {
TapWebViewElementWithId("webScenarioWindowOpenWithAboutNewTabScript");
AssertMainTabCount(2);
[[EarlGrey selectElementWithMatcher:OmniboxText("about:newtab")]
« no previous file with comments | « no previous file | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698