Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2914193003: Automated test case for crbug.com/687863. (Closed)

Created:
3 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 6 months ago
Reviewers:
baxley
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Automated test case for crbug.com/687863. BUG=687863 Review-Url: https://codereview.chromium.org/2914193003 Cr-Commit-Position: refs/heads/master@{#476502} Committed: https://chromium.googlesource.com/chromium/src/+/2bfd0fd3e968ff844ca121035ff9fe352375f62d

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M ios/chrome/browser/web/window_open_by_dom_egtest.mm View 1 chunk +11 lines, -0 lines 3 comments Download
M ios/testing/data/http_server_files/window_open.html View 1 chunk +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Eugene But (OOO till 7-30)
3 years, 6 months ago (2017-06-01 21:01:08 UTC) #2
baxley
lgtm https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/window_open_by_dom_egtest.mm File ios/chrome/browser/web/window_open_by_dom_egtest.mm (right): https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/window_open_by_dom_egtest.mm#newcode205 ios/chrome/browser/web/window_open_by_dom_egtest.mm:205: // target="_blank"> Is this comment too descriptive? Would ...
3 years, 6 months ago (2017-06-01 21:15:02 UTC) #3
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/window_open_by_dom_egtest.mm File ios/chrome/browser/web/window_open_by_dom_egtest.mm (right): https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/window_open_by_dom_egtest.mm#newcode205 ios/chrome/browser/web/window_open_by_dom_egtest.mm:205: // target="_blank"> On 2017/06/01 21:15:02, baxley wrote: > ...
3 years, 6 months ago (2017-06-01 23:24:58 UTC) #4
baxley
lgtm https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/window_open_by_dom_egtest.mm File ios/chrome/browser/web/window_open_by_dom_egtest.mm (right): https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/window_open_by_dom_egtest.mm#newcode205 ios/chrome/browser/web/window_open_by_dom_egtest.mm:205: // target="_blank"> On 2017/06/01 23:24:57, Eugene But wrote: ...
3 years, 6 months ago (2017-06-01 23:40:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914193003/1
3 years, 6 months ago (2017-06-02 00:23:32 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 00:37:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2bfd0fd3e968ff844ca121035ff9...

Powered by Google App Engine
This is Rietveld 408576698