Automated test case for crbug.com/687863.

Automated test case for crbug.com/687863.

BUG=687863
Review-Url: https://codereview.chromium.org/2914193003
Cr-Commit-Position: refs/heads/master@{#476502}
Committed: https://chromium.googlesource.com/chromium/src/+/2bfd0fd3e968ff844ca121035ff9fe352375f62d

[Eugene But (OOO till 7-30), 2017-06-01 21:01:07]

eugenebut@chromium.org changed reviewers:
+ baxley@chromium.org

[baxley, 2017-06-01 21:15:02]

lgtm

https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/wind...
File ios/chrome/browser/web/window_open_by_dom_egtest.mm (right):

https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/wind...
ios/chrome/browser/web/window_open_by_dom_egtest.mm:205: //    target="_blank">
Is this comment too descriptive? Would it be better just to say what it's
attempting to test?

I think the bigger problem is the indirection of having entire test cases in the
html makes it hard to keep things synchronized. Maybe a case of tests that were
written for writeability, rather than readability? I don't expect you to change
anything about the test structure, more just wanted your input.

[Eugene But (OOO till 7-30), 2017-06-01 23:24:58]

Thanks!

https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/wind...
File ios/chrome/browser/web/window_open_by_dom_egtest.mm (right):

https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/wind...
ios/chrome/browser/web/window_open_by_dom_egtest.mm:205: //    target="_blank">
On 2017/06/01 21:15:02, baxley wrote:
> Is this comment too descriptive? Would it be better just to say what it's
> attempting to test?
> 
> I think the bigger problem is the indirection of having entire test cases in
the
> html makes it hard to keep things synchronized. Maybe a case of tests that
were
> written for writeability, rather than readability? I don't expect you to
change
> anything about the test structure, more just wanted your input.
I agree it would be better if these tests used inline HTML, but it is what it is
:(. I wanted to be very specific in the comments, because I don't want people
look into html to figure out what this test does. Do you have any concrete
language in mind to use for comments?

[baxley, 2017-06-01 23:40:15]

lgtm

https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/wind...
File ios/chrome/browser/web/window_open_by_dom_egtest.mm (right):

https://codereview.chromium.org/2914193003/diff/1/ios/chrome/browser/web/wind...
ios/chrome/browser/web/window_open_by_dom_egtest.mm:205: //    target="_blank">
On 2017/06/01 23:24:57, Eugene But wrote:
> On 2017/06/01 21:15:02, baxley wrote:
> > Is this comment too descriptive? Would it be better just to say what it's
> > attempting to test?
> > 
> > I think the bigger problem is the indirection of having entire test cases in
> the
> > html makes it hard to keep things synchronized. Maybe a case of tests that
> were
> > written for writeability, rather than readability? I don't expect you to
> change
> > anything about the test structure, more just wanted your input.
> I agree it would be better if these tests used inline HTML, but it is what it
is
> :(. I wanted to be very specific in the comments, because I don't want people
> look into html to figure out what this test does. Do you have any concrete
> language in mind to use for comments?

No. Anything I suggest would make it less concrete, so may as well leave it as
is.

[Eugene But (OOO till 7-30), 2017-06-02 00:22:43]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-06-02 00:23:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 00:37:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496362963242060, "parent_rev":
"e7b341c528a738a53a71ce8f3090f82805557dcc", "commit_rev":
"35e8d4ef05657c07e91726e73f775658d6b46dc4"}

[commit-bot: I haz the power, 2017-06-02 00:37:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496362963242060, "parent_rev":
"90cf9d727da221f76e5cb7d34aa09c8e711c1e68", "commit_rev":
"2bfd0fd3e968ff844ca121035ff9fe352375f62d"}

[commit-bot: I haz the power, 2017-06-02 00:37:53]

Description was changed from

==========
Automated test case for crbug.com/687863.

BUG=687863
==========

to

==========
Automated test case for crbug.com/687863.

BUG=687863

Review-Url: https://codereview.chromium.org/2914193003
Cr-Commit-Position: refs/heads/master@{#476502}
Committed:
https://chromium.googlesource.com/chromium/src/+/2bfd0fd3e968ff844ca121035ff9...
==========

[commit-bot: I haz the power, 2017-06-02 00:37:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2bfd0fd3e968ff844ca121035ff9...