Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: ios/web/navigation/navigation_manager_impl_unittest.mm

Issue 2918013002: Do not rewrite about urls to chrome:// for cetain renderer-initated loads (Closed)
Patch Set: Self review Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/navigation/navigation_manager_impl.h" 5 #import "ios/web/navigation/navigation_manager_impl.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/mac/bind_objc_block.h"
8 #import "base/mac/scoped_nsobject.h" 9 #import "base/mac/scoped_nsobject.h"
9 #import "ios/web/navigation/crw_session_controller+private_constructors.h" 10 #import "ios/web/navigation/crw_session_controller+private_constructors.h"
10 #import "ios/web/navigation/navigation_manager_delegate.h" 11 #import "ios/web/navigation/navigation_manager_delegate.h"
11 #include "ios/web/public/navigation_item.h" 12 #include "ios/web/public/navigation_item.h"
12 #include "ios/web/public/test/fakes/test_browser_state.h" 13 #include "ios/web/public/test/fakes/test_browser_state.h"
13 #include "ios/web/test/test_url_constants.h" 14 #include "ios/web/test/test_url_constants.h"
14 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
15 #include "testing/platform_test.h" 16 #include "testing/platform_test.h"
17 #include "url/scheme_host_port.h"
18 #include "url/url_util.h"
16 19
17 namespace web { 20 namespace web {
18 namespace { 21 namespace {
22
23 // URL scheme that will be rewritten by UrlRewriter installed in
24 // NavigationManagerTest fixture. Scheme will be changed to kTestWebUIScheme.
25 const char kSchemeToRewrite[] = "navigationmanagerschemetorewrite";
26
27 // Replaces |kSchemeToRewrite| scheme with |kTestWebUIScheme|.
28 bool UrlRewriter(GURL* url, BrowserState* browser_state) {
29 if (url->scheme() == kSchemeToRewrite) {
30 GURL::Replacements scheme_replacements;
31 scheme_replacements.SetSchemeStr(kTestWebUIScheme);
32 *url = url->ReplaceComponents(scheme_replacements);
33 }
34 return false;
35 }
36
19 // Stub class for NavigationManagerDelegate. 37 // Stub class for NavigationManagerDelegate.
20 class TestNavigationManagerDelegate : public NavigationManagerDelegate { 38 class TestNavigationManagerDelegate : public NavigationManagerDelegate {
21 public: 39 public:
22 bool reload_called() { return reload_called_; } 40 bool reload_called() { return reload_called_; }
23 41
24 private: 42 private:
25 // NavigationManagerDelegate overrides. 43 // NavigationManagerDelegate overrides.
26 void GoToIndex(int index) override {} 44 void GoToIndex(int index) override {}
27 void LoadURLWithParams(const NavigationManager::WebLoadParams&) override {} 45 void LoadURLWithParams(const NavigationManager::WebLoadParams&) override {}
28 void Reload() override { reload_called_ = true; } 46 void Reload() override { reload_called_ = true; }
29 void OnNavigationItemsPruned(size_t pruned_item_count) override {} 47 void OnNavigationItemsPruned(size_t pruned_item_count) override {}
30 void OnNavigationItemChanged() override{}; 48 void OnNavigationItemChanged() override{};
31 void OnNavigationItemCommitted(const LoadCommittedDetails&) override {} 49 void OnNavigationItemCommitted(const LoadCommittedDetails&) override {}
32 WebState* GetWebState() override { return nullptr; } 50 WebState* GetWebState() override { return nullptr; }
33 51
34 bool reload_called_ = false; 52 bool reload_called_ = false;
35 }; 53 };
36 } // namespace 54 } // namespace
37 55
38 // Test fixture for NavigationManagerImpl testing. 56 // Test fixture for NavigationManagerImpl testing.
39 class NavigationManagerTest : public PlatformTest { 57 class NavigationManagerTest : public PlatformTest {
40 protected: 58 protected:
41 NavigationManagerTest() : manager_(new NavigationManagerImpl()) { 59 NavigationManagerTest() : manager_(new NavigationManagerImpl()) {
60 // Setup rewriter.
61 BrowserURLRewriter::GetInstance()->AddURLRewriter(UrlRewriter);
62 url::AddStandardScheme(kSchemeToRewrite, url::SCHEME_WITHOUT_PORT);
63
42 manager_->SetDelegate(&delegate_); 64 manager_->SetDelegate(&delegate_);
43 manager_->SetBrowserState(&browser_state_); 65 manager_->SetBrowserState(&browser_state_);
44 controller_.reset( 66 controller_.reset(
45 [[CRWSessionController alloc] initWithBrowserState:&browser_state_]); 67 [[CRWSessionController alloc] initWithBrowserState:&browser_state_]);
46 manager_->SetSessionController(controller_.get()); 68 manager_->SetSessionController(controller_.get());
47 } 69 }
48 CRWSessionController* session_controller() { return controller_.get(); } 70 CRWSessionController* session_controller() { return controller_.get(); }
49 NavigationManagerImpl* navigation_manager() { return manager_.get(); } 71 NavigationManagerImpl* navigation_manager() { return manager_.get(); }
50 TestNavigationManagerDelegate navigation_manager_delegate() { 72 TestNavigationManagerDelegate navigation_manager_delegate() {
51 return delegate_; 73 return delegate_;
(...skipping 1240 matching lines...) Expand 10 before | Expand all | Expand 10 after
1292 1314
1293 navigation_manager()->Reload(web::ReloadType::ORIGINAL_REQUEST_URL, 1315 navigation_manager()->Reload(web::ReloadType::ORIGINAL_REQUEST_URL,
1294 false /* check_for_repost */); 1316 false /* check_for_repost */);
1295 EXPECT_TRUE(navigation_manager_delegate().reload_called()); 1317 EXPECT_TRUE(navigation_manager_delegate().reload_called());
1296 1318
1297 ASSERT_TRUE(navigation_manager()->GetLastCommittedItem()); 1319 ASSERT_TRUE(navigation_manager()->GetLastCommittedItem());
1298 EXPECT_EQ(expected_original_url, 1320 EXPECT_EQ(expected_original_url,
1299 navigation_manager()->GetLastCommittedItem()->GetURL()); 1321 navigation_manager()->GetLastCommittedItem()->GetURL());
1300 } 1322 }
1301 1323
1324 // Tests that app-specific URLs are not rewritten for renderer-initiated loads
1325 // unless requested by a page with app-specific url.
1326 TEST_F(NavigationManagerTest, RewritingAppSpecificUrls) {
1327 // URL should not be rewritten as there is no committed URL.
1328 GURL url1(url::SchemeHostPort(kSchemeToRewrite, "test", 0).Serialize());
1329 navigation_manager()->AddPendingItem(
1330 url1, Referrer(), ui::PAGE_TRANSITION_LINK,
1331 web::NavigationInitiationType::RENDERER_INITIATED,
1332 web::NavigationManager::UserAgentOverrideOption::INHERIT);
1333 EXPECT_EQ(url1, navigation_manager()->GetPendingItem()->GetURL());
1334
1335 // URL should not be rewritten because last committed URL is not app-specific.
1336 [session_controller() commitPendingItem];
1337 GURL url2(url::SchemeHostPort(kSchemeToRewrite, "test2", 0).Serialize());
1338 navigation_manager()->AddPendingItem(
1339 url2, Referrer(), ui::PAGE_TRANSITION_LINK,
1340 web::NavigationInitiationType::RENDERER_INITIATED,
1341 web::NavigationManager::UserAgentOverrideOption::INHERIT);
1342 EXPECT_EQ(url2, navigation_manager()->GetPendingItem()->GetURL());
1343
1344 // URL should be rewritten for user initiated navigations.
1345 GURL url3(url::SchemeHostPort(kSchemeToRewrite, "test3", 0).Serialize());
1346 navigation_manager()->AddPendingItem(
1347 url3, Referrer(), ui::PAGE_TRANSITION_LINK,
1348 web::NavigationInitiationType::USER_INITIATED,
1349 web::NavigationManager::UserAgentOverrideOption::INHERIT);
1350 GURL rewritten_url3(
1351 url::SchemeHostPort(kTestWebUIScheme, "test3", 0).Serialize());
1352 EXPECT_EQ(rewritten_url3, navigation_manager()->GetPendingItem()->GetURL());
1353
1354 // URL should be rewritten because last committed URL is app-specific.
1355 [session_controller() commitPendingItem];
1356 GURL url4(url::SchemeHostPort(kSchemeToRewrite, "test4", 0).Serialize());
1357 navigation_manager()->AddPendingItem(
1358 url4, Referrer(), ui::PAGE_TRANSITION_LINK,
1359 web::NavigationInitiationType::RENDERER_INITIATED,
1360 web::NavigationManager::UserAgentOverrideOption::INHERIT);
1361 GURL rewritten_url4(
1362 url::SchemeHostPort(kTestWebUIScheme, "test4", 0).Serialize());
1363 EXPECT_EQ(rewritten_url4, navigation_manager()->GetPendingItem()->GetURL());
1364 }
1365
1302 } // namespace web 1366 } // namespace web
OLDNEW
« no previous file with comments | « ios/web/navigation/crw_session_controller.mm ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698