[Notifications] Only set defaults and vibration pattern when explicitly set.

[Notifications] Only set defaults and vibration pattern when explicitly set.

Cleans up a poor assumption about channel definitions.
BUG=729111
Review-Url: https://codereview.chromium.org/2916243005
Cr-Commit-Position: refs/heads/master@{#476980}
Committed: https://chromium.googlesource.com/chromium/src/+/3357f82e8c79423a4446984c048f7ed3ad4048db

[Yaron, 2017-06-02 18:43:41]

yfriedman@chromium.org changed reviewers:
+ awdf@chromium.org

[Yaron, 2017-06-02 18:43:45]

The CQ bit was checked by yfriedman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 18:44:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 20:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 20:08:10]

Dry run: This issue passed the CQ dry run.

[awdf, 2017-06-05 11:21:22]

lgtm

https://codereview.chromium.org/2916243005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java
(right):

https://codereview.chromium.org/2916243005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java:123:
protected Integer mDefaults;
nit: I think it would be neater to keep this as an int & always call setDefaults
- if it's still zero this should be a no-op, from looking at the implementation
of Notification/Notification.Builder.

[Yaron, 2017-06-05 13:22:29]

https://codereview.chromium.org/2916243005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java
(right):

https://codereview.chromium.org/2916243005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java:123:
protected Integer mDefaults;
On 2017/06/05 11:21:22, awdf wrote:
> nit: I think it would be neater to keep this as an int & always call
setDefaults
> - if it's still zero this should be a no-op, from looking at the
implementation
> of Notification/Notification.Builder.

Done.

[Yaron, 2017-06-05 13:22:40]

The CQ bit was checked by yfriedman@chromium.org

[Yaron, 2017-06-05 13:22:41]

The patchset sent to the CQ was uploaded after l-g-t-m from awdf@chromium.org
Link to the patchset: https://codereview.chromium.org/2916243005/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-06-05 13:22:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 14:13:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496668960758940,
"parent_rev": "e071f50ba3e8d0024eb92a019b2c35e223788e32", "commit_rev":
"3357f82e8c79423a4446984c048f7ed3ad4048db"}

[commit-bot: I haz the power, 2017-06-05 14:13:37]

Description was changed from

==========
[Notifications] Only set defaults and vibration pattern when explicitly set.

Cleans up a poor assumption about channel definitions.
BUG=729111
==========

to

==========
[Notifications] Only set defaults and vibration pattern when explicitly set.

Cleans up a poor assumption about channel definitions.
BUG=729111

Review-Url: https://codereview.chromium.org/2916243005
Cr-Commit-Position: refs/heads/master@{#476980}
Committed:
https://chromium.googlesource.com/chromium/src/+/3357f82e8c79423a4446984c048f...
==========

[commit-bot: I haz the power, 2017-06-05 14:13:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3357f82e8c79423a4446984c048f...