Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2341)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

Issue 2916243005: [Notifications] Only set defaults and vibration pattern when explicitly set. (Closed)
Patch Set: nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
index ff3d347fc6058e975b50c9178c123adba44f6f16..e5f62083bfafbc4643debb964b396adb53222b28 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
@@ -148,11 +148,8 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {
builder.setContentIntent(mContentIntent);
builder.setDeleteIntent(mDeleteIntent);
builder.setPriority(mPriority);
- // Browser channel uses silent notifications to avoid disrupting the user.
- if (!ChannelDefinitions.CHANNEL_ID_BROWSER.equals(mChannelId)) {
- builder.setDefaults(mDefaults);
- builder.setVibrate(mVibratePattern);
- }
+ builder.setDefaults(mDefaults);
+ if (mVibratePattern != null) builder.setVibrate(mVibratePattern);
builder.setWhen(mTimestamp);
builder.setOnlyAlertOnce(!mRenotify);
builder.setContent(compactView);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698