Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4516)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

Issue 2916243005: [Notifications] Only set defaults and vibration pattern when explicitly set. (Closed)
Patch Set: nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
index c39a2e2923b11f2d48c8ce10f26bd2dd5989bca9..4a25bedae993199f1bc4afcecf9a058e8c65c20e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
@@ -59,11 +59,8 @@ public class StandardNotificationBuilder extends NotificationBuilderBase {
addActionToBuilder(builder, mSettingsAction);
}
builder.setPriority(mPriority);
- // Browser channel uses silent notifications to avoid disrupting the user.
- if (!ChannelDefinitions.CHANNEL_ID_BROWSER.equals(mChannelId)) {
- builder.setDefaults(mDefaults);
- builder.setVibrate(mVibratePattern);
- }
+ builder.setDefaults(mDefaults);
+ if (mVibratePattern != null) builder.setVibrate(mVibratePattern);
builder.setWhen(mTimestamp);
builder.setOnlyAlertOnce(!mRenotify);
setGroupOnBuilder(builder, mOrigin);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698