chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java - Issue 2916243005: [Notifications] Only set defaults and vibration pattern when explicitly set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java

Issue 2916243005: [Notifications] Only set defaults and vibration pattern when explicitly set. (Closed)

Patch Set: nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java

index 00a1069f3eb61c574b79e2b312c1db02e59f3600..9843a996e4f622cf1c94f35f743a7e3cd9391243 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java

@@ -120,7 +120,7 @@ public abstract class NotificationBuilderBase {

protected PendingIntent mDeleteIntent;

protected List<Action> mActions = new ArrayList<>(MAX_AUTHOR_PROVIDED_ACTION_BUTTONS);

protected Action mSettingsAction;

- protected int mDefaults = Notification.DEFAULT_ALL;

+ protected int mDefaults;

protected long[] mVibratePattern;

protected long mTimestamp;

protected boolean mRenotify;