PDF Plugin: Add compile targets for a few more files.

PDF Plugin: Add compile targets for a few more files.

 - browser_api
 - viewer-bookmark
 - viewer-error-screen
 - viewer-page-indicator
 - viewer-page-selector
 - viewer-password-screen

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2915773003
Cr-Commit-Position: refs/heads/master@{#476879}
Committed: https://chromium.googlesource.com/chromium/src/+/9b2a8220cc2d621aad2a53f704b9ba9cd0ef183e

[dpapad, 2017-06-01 01:09:54]

Description was changed from

==========
PDF Plugin: Add compile targets for a few files.

 - browser_api

BUG=721073
==========

to

==========
PDF Plugin: Add compile targets for a few files.

 - browser_api

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-01 18:38:36]

Description was changed from

==========
PDF Plugin: Add compile targets for a few files.

 - browser_api

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF Plugin: Add compile targets for a few files.

 - browser_api
 - viewer-bookmark
 - viewer-error-screen
 - viewer-page-indicator

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-01 18:38:56]

Description was changed from

==========
PDF Plugin: Add compile targets for a few files.

 - browser_api
 - viewer-bookmark
 - viewer-error-screen
 - viewer-page-indicator

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF Plugin: Add compile targets for a few files.

 - browser_api
 - viewer-bookmark
 - viewer-error-screen
 - viewer-page-indicator
 - viewer-page-selector
 - viewer-password-screen

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-01 18:41:11]

Description was changed from

==========
PDF Plugin: Add compile targets for a few files.

 - browser_api
 - viewer-bookmark
 - viewer-error-screen
 - viewer-page-indicator
 - viewer-page-selector
 - viewer-password-screen

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF Plugin: Add compile targets for a few more files.

 - browser_api
 - viewer-bookmark
 - viewer-error-screen
 - viewer-page-indicator
 - viewer-page-selector
 - viewer-password-screen

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-01 19:12:05]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-06-02 21:15:36]

On 2017/06/01 at 19:12:06, dpapad wrote:
> 

Friendly ping.

[Dan Beam, 2017-06-02 21:57:00]

lgtm

https://codereview.chromium.org/2915773003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/pdf/compiled_resources2.gyp (right):

https://codereview.chromium.org/2915773003/diff/60001/chrome/browser/resource...
chrome/browser/resources/pdf/compiled_resources2.gyp:11:
'<(DEPTH)/third_party/closure_compiler/externs/compiled_resources2.gyp:chrome_extensions',
'<(EXTERNS_GYP):chrome_extensions',
'<(EXTERNS_GYP):mime_handler_private',

https://codereview.chromium.org/2915773003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/pdf/elements/viewer-page-selector/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2915773003/diff/60001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/viewer-page-selector/compiled_resources2.gyp:10:
],
nit: can you just remove?

[dpapad, 2017-06-02 22:20:30]

https://codereview.chromium.org/2915773003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/pdf/compiled_resources2.gyp (right):

https://codereview.chromium.org/2915773003/diff/60001/chrome/browser/resource...
chrome/browser/resources/pdf/compiled_resources2.gyp:11:
'<(DEPTH)/third_party/closure_compiler/externs/compiled_resources2.gyp:chrome_extensions',
On 2017/06/02 at 21:57:00, Dan Beam wrote:
> '<(EXTERNS_GYP):chrome_extensions',
> '<(EXTERNS_GYP):mime_handler_private',

Done.

https://codereview.chromium.org/2915773003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/pdf/elements/viewer-page-selector/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2915773003/diff/60001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/viewer-page-selector/compiled_resources2.gyp:10:
],
On 2017/06/02 at 21:57:00, Dan Beam wrote:
> nit: can you just remove?

Done.

[dpapad, 2017-06-02 22:20:39]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-06-02 22:20:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2915773003/#ps80001
(title: "Addressing comments.")

[commit-bot: I haz the power, 2017-06-02 22:21:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 02:01:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 02:01:06]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dpapad, 2017-06-03 02:02:37]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-06-03 02:03:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 03:05:59]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496455357526470,
"parent_rev": "0e0221f193ff2027ee5eaf39fb8e9b5f728a23b6", "commit_rev":
"9b2a8220cc2d621aad2a53f704b9ba9cd0ef183e"}

[commit-bot: I haz the power, 2017-06-03 03:06:07]

Description was changed from

==========
PDF Plugin: Add compile targets for a few more files.

 - browser_api
 - viewer-bookmark
 - viewer-error-screen
 - viewer-page-indicator
 - viewer-page-selector
 - viewer-password-screen

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF Plugin: Add compile targets for a few more files.

 - browser_api
 - viewer-bookmark
 - viewer-error-screen
 - viewer-page-indicator
 - viewer-page-selector
 - viewer-password-screen

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2915773003
Cr-Commit-Position: refs/heads/master@{#476879}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b2a8220cc2d621aad2a53f704b9...
==========

[commit-bot: I haz the power, 2017-06-03 03:06:09]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9b2a8220cc2d621aad2a53f704b9...