chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js - Issue 2915773003: PDF Plugin: Add compile targets for a few more files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js

Issue 2915773003: PDF Plugin: Add compile targets for a few more files. (Closed)

Patch Set: Addressing comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-error-screen/compiled_resources2.gyp ('k') | chrome/browser/resources/pdf/elements/viewer-page-indicator/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js b/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js

index 29951a43c1b18da863f3d1e6720a363759e28ab8..017d4747c05a5839838484776ac5ebde71f20d1d 100644

--- a/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js

+++ b/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js

@@ -5,13 +5,13 @@

Polymer({

is: 'viewer-error-screen',

properties: {

- reloadFn: Object,

+ reloadFn: Function,

strings: Object,

show: function() {

- this.$.dialog.showModal();

+ /** @type {!CrDialogElement} */ (this.$.dialog).showModal();

reload: function() {