chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js - Issue 2915773003: PDF Plugin: Add compile targets for a few more files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js

Issue 2915773003: PDF Plugin: Add compile targets for a few more files. (Closed)

Patch Set: Addressing comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-page-indicator/compiled_resources2.gyp ('k') | chrome/browser/resources/pdf/elements/viewer-page-selector/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js b/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js

index 65b1be2ffc3ae948e3d305794ba4803fc3151d2a..09f1b8012388bdfca4d9cd9fdf78f80d8b44ad9f 100644

--- a/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js

+++ b/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js

@@ -23,8 +23,10 @@ Polymer({

}

+ /** @type {number|undefined} */

timerId: undefined,

+ /** @override */

ready: function() {

var callback = this.fadeIn.bind(this, 2000);

window.addEventListener('scroll', function() {

@@ -36,6 +38,7 @@ Polymer({

this.fadeIn(6000);

+ /** @param {number} displayTime */

fadeIn: function(displayTime) {

var percent = window.scrollY /

(document.body.scrollHeight -