chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js - Issue 2915773003: PDF Plugin: Add compile targets for a few more files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

Issue 2915773003: PDF Plugin: Add compile targets for a few more files. (Closed)

Patch Set: Addressing comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-page-selector/compiled_resources2.gyp ('k') | chrome/browser/resources/pdf/elements/viewer-password-screen/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

index ad344f60e138341a7f7ae3f73a870e8ae5076945..12188d7d57d79d861cecb25c5b377068f072791b 100644

--- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

+++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

@@ -12,7 +12,7 @@ Polymer({

docLength: {

type: Number,

value: 1,

- observer: 'docLengthChanged'

+ observer: 'docLengthChanged_'

/**

@@ -29,7 +29,7 @@ Polymer({

pageNoCommitted: function() {

- var page = parseInt(this.$.input.value);

+ var page = parseInt(this.$.input.value, 10);

if (!isNaN(page) && page <= this.docLength && page > 0)

this.fire('change-page', {page: page - 1});

@@ -38,7 +38,8 @@ Polymer({

this.$.input.blur();

- docLengthChanged: function() {

+ /** @private */

+ docLengthChanged_: function() {

var numDigits = this.docLength.toString().length;

this.$.pageselector.style.width = numDigits + 'ch';

// Set both sides of the slash to the same width, so that the layout is