Remove unused BidirectionalStream::SendData() method and implementations.

Remove unused BidirectionalStream::SendData() method and implementations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2915053003
Cr-Commit-Position: refs/heads/master@{#476581}
Committed: https://chromium.googlesource.com/chromium/src/+/ad39988f99e82fc0c9e0a389d4d9bf98590ab093

[Ryan Hamilton, 2017-06-01 19:50:27]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 19:51:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2017-06-01 19:52:13]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 19:52:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2017-06-01 20:38:00]

Description was changed from

==========
Remove unused BidirectionalStream::SendData() method and implementations.
==========

to

==========
Remove unused BidirectionalStream::SendData() method and implementations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[Ryan Hamilton, 2017-06-01 21:14:46]

rch@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Ryan Hamilton, 2017-06-01 21:14:47]

It looks like we can just use SendvData() instead of SendData() to simplify the
code.

[Ryan Hamilton, 2017-06-01 21:42:36]

Patchset #5 (id:80001) has been deleted

[xunjieli, 2017-06-01 21:49:59]

https://codereview.chromium.org/2915053003/diff/60001/net/spdy/chromium/bidir...
File net/spdy/chromium/bidirectional_stream_spdy_impl.cc (right):

https://codereview.chromium.org/2915053003/diff/60001/net/spdy/chromium/bidir...
net/spdy/chromium/bidirectional_stream_spdy_impl.cc:143:
memcpy(pending_combined_buffer_->data() + len, buffers[i]->data(),
When BidirectionalStreamSpdyImpl::SendData is gone, if we send one IOBuffer, we
will incur a memcpy. Could you add a check on |buffers|. If it's of length 1, we
skip the memcpy?

[Ryan Hamilton, 2017-06-01 21:57:20]

Thanks!

https://codereview.chromium.org/2915053003/diff/60001/net/spdy/chromium/bidir...
File net/spdy/chromium/bidirectional_stream_spdy_impl.cc (right):

https://codereview.chromium.org/2915053003/diff/60001/net/spdy/chromium/bidir...
net/spdy/chromium/bidirectional_stream_spdy_impl.cc:143:
memcpy(pending_combined_buffer_->data() + len, buffers[i]->data(),
On 2017/06/01 21:49:59, xunjieli (Slow.until.6-5) wrote:
> When BidirectionalStreamSpdyImpl::SendData is gone, if we send one IOBuffer,
we
> will incur a memcpy. Could you add a check on |buffers|. If it's of length 1,
we
> skip the memcpy?

Good point. Done.

[xunjieli, 2017-06-01 22:18:12]

lgtm

[Ryan Hamilton, 2017-06-02 02:43:29]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-06-02 02:43:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2915053003/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-02 02:43:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 03:15:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 03:15:49]

Try jobs failed on following builders:
  android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hamilton, 2017-06-02 03:59:16]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-06-02 03:59:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2915053003/#ps160001
(title: "Fix")

[commit-bot: I haz the power, 2017-06-02 03:59:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 05:34:37]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1496375956619590,
"parent_rev": "9e887928f5fc67b86d3d2bf951c3022caaa2314e", "commit_rev":
"ad39988f99e82fc0c9e0a389d4d9bf98590ab093"}

[commit-bot: I haz the power, 2017-06-02 05:34:45]

Description was changed from

==========
Remove unused BidirectionalStream::SendData() method and implementations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Remove unused BidirectionalStream::SendData() method and implementations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2915053003
Cr-Commit-Position: refs/heads/master@{#476581}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad39988f99e82fc0c9e0a389d4d9...
==========

[commit-bot: I haz the power, 2017-06-02 05:34:46]

Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/ad39988f99e82fc0c9e0a389d4d9...