Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Unified Diff: net/http/bidirectional_stream_unittest.cc

Issue 2915053003: Remove unused BidirectionalStream::SendData() method and implementations. (Closed)
Patch Set: Fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/bidirectional_stream_impl.h ('k') | net/log/net_log_event_type_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/bidirectional_stream_unittest.cc
diff --git a/net/http/bidirectional_stream_unittest.cc b/net/http/bidirectional_stream_unittest.cc
index 6d62d57b1c451889754dc30296be3eccbf00960a..037a21eafd99339e4828189734848dcbc8e1c049 100644
--- a/net/http/bidirectional_stream_unittest.cc
+++ b/net/http/bidirectional_stream_unittest.cc
@@ -184,9 +184,7 @@ class TestDelegateBase : public BidirectionalStream::Delegate {
void SendData(const scoped_refptr<IOBuffer>& data,
int length,
bool end_of_stream) {
- not_expect_callback_ = true;
- stream_->SendData(data, length, end_of_stream);
- not_expect_callback_ = false;
+ SendvData({data}, {length}, end_of_stream);
}
void SendvData(const std::vector<scoped_refptr<IOBuffer>>& data,
@@ -769,7 +767,7 @@ TEST_F(BidirectionalStreamTest, TestNetLogContainEntries) {
entries, index, NetLogEventType::BIDIRECTIONAL_STREAM_RECV_TRAILERS,
NetLogEventPhase::NONE);
index = ExpectLogContainsSomewhere(
- entries, index, NetLogEventType::BIDIRECTIONAL_STREAM_SEND_DATA,
+ entries, index, NetLogEventType::BIDIRECTIONAL_STREAM_SENDV_DATA,
NetLogEventPhase::NONE);
index = ExpectLogContainsSomewhere(
entries, index, NetLogEventType::BIDIRECTIONAL_STREAM_READ_DATA,
« no previous file with comments | « net/http/bidirectional_stream_impl.h ('k') | net/log/net_log_event_type_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698