Remove unused BidirectionalStream::SendData() method and implementations.

net/spdy/chromium/bidirectional_stream_spdy_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/chromium/bidirectional_stream_spdy_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 92 matching lines @@
   } else if (stream_closed_) {
     return closed_stream_status_;
   }
   // Read will complete asynchronously and Delegate::OnReadCompleted will be
   // called upon completion.
   read_buffer_ = buf;
   read_buffer_len_ = buf_len;
   return ERR_IO_PENDING;
 }
 
-void BidirectionalStreamSpdyImpl::SendData(const scoped_refptr<IOBuffer>& data,
-                                           int length,
-                                           bool end_stream) {
-  DCHECK(length > 0 || (length == 0 && end_stream));
-  DCHECK(!write_pending_);
-
-  if (written_end_of_stream_) {
-    LOG(ERROR) << "Writing after end of stream is written.";
-    base::ThreadTaskRunnerHandle::Get()->PostTask(
-        FROM_HERE, base::Bind(&BidirectionalStreamSpdyImpl::NotifyError,
-                              weak_factory_.GetWeakPtr(), ERR_UNEXPECTED));
-    return;
-  }
-
-  write_pending_ = true;
-  written_end_of_stream_ = end_stream;
-  if (MaybeHandleStreamClosedInSendData())
-    return;
-
-  DCHECK(!stream_closed_);
-  stream_->SendData(data.get(), length,
-                    end_stream ? NO_MORE_DATA_TO_SEND : MORE_DATA_TO_SEND);
-}
-
 void BidirectionalStreamSpdyImpl::SendvData(
     const std::vector<scoped_refptr<IOBuffer>>& buffers,
     const std::vector<int>& lengths,
     bool end_stream) {
   DCHECK_EQ(buffers.size(), lengths.size());
   DCHECK(!write_pending_);
 
   if (written_end_of_stream_) {
     LOG(ERROR) << "Writing after end of stream is written.";
     base::ThreadTaskRunnerHandle::Get()->PostTask(
@@ skipping 10 matching lines @@
   DCHECK(!stream_closed_);
   int total_len = 0;
   for (int len : lengths) {
     total_len += len;
   }
 
   pending_combined_buffer_ = new net::IOBuffer(total_len);
   int len = 0;
   // TODO(xunjieli): Get rid of extra copy. Coalesce headers and data frames.
   for (size_t i = 0; i < buffers.size(); ++i) {
     memcpy(pending_combined_buffer_->data() + len, buffers[i]->data(),

[xunjieli, 2017/06/01 21:49:59]

When BidirectionalStreamSpdyImpl::SendData is gone, if we send one IOBuffer, we
will incur a memcpy. Could you add a check on |buffers|. If it's of length 1, we
skip the memcpy?

[Ryan Hamilton, 2017/06/01 21:57:20]

Good point. Done.

            lengths[i]);
     len += lengths[i];
   }
   stream_->SendData(pending_combined_buffer_.get(), total_len,
                     end_stream ? NO_MORE_DATA_TO_SEND : MORE_DATA_TO_SEND);
 }
 
 NextProto BidirectionalStreamSpdyImpl::GetProtocol() const {
   return negotiated_protocol_;
 }
@@ skipping 237 matching lines @@
     return true;
   }
   LOG(ERROR) << "Trying to send data after stream has been destroyed.";
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(&BidirectionalStreamSpdyImpl::NotifyError,
                             weak_factory_.GetWeakPtr(), ERR_UNEXPECTED));
   return true;
 }
 
 }  // namespace net