Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2920873002: Ensure that BidirectionalStreamQuicImpl does not synchronously invoke callbacks (Closed)

Created:
3 years, 6 months ago by Ryan Hamilton
Modified:
3 years, 6 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that BidirectionalStreamQuicImpl does not synchronously invoke callbacks to the delegate. Change Start() to invoke OnStreamReady() asynchronously. Review-Url: https://codereview.chromium.org/2920873002 Cr-Commit-Position: refs/heads/master@{#476645} Committed: https://chromium.googlesource.com/chromium/src/+/cc1d4221ecff47ed19ce3106987ad0e7afab788a

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.cc View 1 2 11 chunks +32 lines, -1 line 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
Ryan Hamilton
3 years, 6 months ago (2017-06-01 19:21:07 UTC) #2
xunjieli
LGTM. This looks great. Thank you.
3 years, 6 months ago (2017-06-02 12:44:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920873002/60001
3 years, 6 months ago (2017-06-02 13:21:50 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 14:50:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cc1d4221ecff47ed19ce3106987a...

Powered by Google App Engine
This is Rietveld 408576698