Change return type of TextIterator::HandleXXX to void

Change return type of TextIterator::HandleXXX to void

TextIterator used to have the following member functions returning |bool|
to indicate whether the handling of a node is complete or not:
- HandleTextNode
- HandleReplacedElement
- HandleNonTextNode

However, the return value has become arbitrary and not that useful after
the class has evolved for so many years. Hence, this patch removes their
return value to make the state change in TextIterator clean.

BUG=721957
TEST=n/a; shouldn't have any behavioral change

Review-Url: https://codereview.chromium.org/2914883002
Cr-Commit-Position: refs/heads/master@{#476144}
Committed: https://chromium.googlesource.com/chromium/src/+/d2ec4830b36d30ebf8ab495d18a6282db1020db1

[Xiaocheng, 2017-05-31 18:46:20]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 18:47:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-31 18:51:05]

Description was changed from

==========
Change return type of TextIterator::HandleXXX to void

BUG=
==========

to

==========
Change return type of TextIterator::HandleXXX to void

TextIterator used to have the following member functions returning |bool|
to indicate whether the handling of a node is complete or not:
- HandleTextNode
- HandleReplacedElement
- HandleNonTextNode

However, the return value has become arbitrary and not that useful after
the class has evolved for so many years. Hence, this patch removes their
return value to make the state change in TextIterator clean.

BUG=
==========

[Xiaocheng, 2017-05-31 18:51:25]

Description was changed from

==========
Change return type of TextIterator::HandleXXX to void

TextIterator used to have the following member functions returning |bool|
to indicate whether the handling of a node is complete or not:
- HandleTextNode
- HandleReplacedElement
- HandleNonTextNode

However, the return value has become arbitrary and not that useful after
the class has evolved for so many years. Hence, this patch removes their
return value to make the state change in TextIterator clean.

BUG=
==========

to

==========
Change return type of TextIterator::HandleXXX to void

TextIterator used to have the following member functions returning |bool|
to indicate whether the handling of a node is complete or not:
- HandleTextNode
- HandleReplacedElement
- HandleNonTextNode

However, the return value has become arbitrary and not that useful after
the class has evolved for so many years. Hence, this patch removes their
return value to make the state change in TextIterator clean.

BUG=721957
TEST=n/a; shouldn't have any behavioral change
==========

[Xiaocheng, 2017-05-31 19:19:34]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-31 19:19:34]

PTAL.

[commit-bot: I haz the power, 2017-05-31 21:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:03:28]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-06-01 01:31:52]

lgtm

Thanks for doing this.
This patch makes TextIterator code cleaner and exposes more places to use
early-return style
to reduce indentation and simpler code.

https://codereview.chromium.org/2914883002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp (right):

https://codereview.chromium.org/2914883002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:549: if
(EmitsImageAltText() && TextIterator::SupportsAltText(node_)) {
FYI: Subject to change early return style.

https://codereview.chromium.org/2914883002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:772: if
(ShouldEmitNewlineForNode(node_, EmitsOriginalText()))
FYI: Subject to change early-return style.

https://codereview.chromium.org/2914883002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp
(right):

https://codereview.chromium.org/2914883002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp:162:
if (layout_object->Style()->Visibility() == EVisibility::kVisible ||
FYI: Subject to change early-return style.

[xiaochengh, 2017-06-01 01:47:54]

The CQ bit was checked by xiaochengh@google.com

[commit-bot: I haz the power, 2017-06-01 01:48:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 01:54:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496281674345350, "parent_rev":
"4ed6aee2484e96b28b55d6774c9e1cf6c308b07d", "commit_rev":
"d2ec4830b36d30ebf8ab495d18a6282db1020db1"}

[commit-bot: I haz the power, 2017-06-01 01:54:25]

Description was changed from

==========
Change return type of TextIterator::HandleXXX to void

TextIterator used to have the following member functions returning |bool|
to indicate whether the handling of a node is complete or not:
- HandleTextNode
- HandleReplacedElement
- HandleNonTextNode

However, the return value has become arbitrary and not that useful after
the class has evolved for so many years. Hence, this patch removes their
return value to make the state change in TextIterator clean.

BUG=721957
TEST=n/a; shouldn't have any behavioral change
==========

to

==========
Change return type of TextIterator::HandleXXX to void

TextIterator used to have the following member functions returning |bool|
to indicate whether the handling of a node is complete or not:
- HandleTextNode
- HandleReplacedElement
- HandleNonTextNode

However, the return value has become arbitrary and not that useful after
the class has evolved for so many years. Hence, this patch removes their
return value to make the state change in TextIterator clean.

BUG=721957
TEST=n/a; shouldn't have any behavioral change

Review-Url: https://codereview.chromium.org/2914883002
Cr-Commit-Position: refs/heads/master@{#476144}
Committed:
https://chromium.googlesource.com/chromium/src/+/d2ec4830b36d30ebf8ab495d18a6...
==========

[commit-bot: I haz the power, 2017-06-01 01:54:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2ec4830b36d30ebf8ab495d18a6...