Use remembered progress to handle replaced elements in TextIterator

Use remembered progress to handle replaced elements in TextIterator

This patch utilizes the "remembered progress" mechanism in TextIterator
to handle a replaced element when it emits multiple text runs. In this
way, the control flow becomes cleaner as we don't need to go into the
mail loop of TextIterator::Advance() again.

Follow-up patches will remove the return value of HandlePlacedElement()
because this patch makes it almost useless.

BUG=721957
TEST=n/a; shouldn't have any behavioral change

Review-Url: https://codereview.chromium.org/2912283002
Cr-Commit-Position: refs/heads/master@{#475977}
Committed: https://chromium.googlesource.com/chromium/src/+/529b9affa165a95a6b9369809ab26d7c5d37466b

[Xiaocheng, 2017-05-31 05:18:42]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 05:18:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-31 05:39:03]

Description was changed from

==========
Use remembered progress to handle replaced elements in TextIterator

BUG=
==========

to

==========
Use remembered progress to handle replaced elements in TextIterator

This patch utilizes the "remembered progress" mechanism in TextIterator
to handle a replaced element when it emits multiple text runs. In this
way, the control flow becomes cleaner as we don't need to go into the
mail loop of TextIterator::Advance() again.

Follow-up patches will remove the return value of HandlePlacedElement()
because this patch makes it almost useless.

BUG=721957
TEST=n/a; shouldn't have any behavioral change
==========

[Xiaocheng, 2017-05-31 06:41:55]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-31 06:41:55]

PTAL.

[yosin_UTC9, 2017-05-31 07:23:01]

lgtm w/ nit

https://codereview.chromium.org/2912283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/iterators/TextIterator.h (right):

https://codereview.chromium.org/2912283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.h:227: bool
needs_handle_replaced_element_;
nit: Initialize needs_handle_replaced_element_ here instead of ctor.

Should we have another patch to move member initialization to class decl?

[commit-bot: I haz the power, 2017-05-31 07:23:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 07:23:57]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-31 18:05:54]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-31 18:05:58]

https://codereview.chromium.org/2912283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/iterators/TextIterator.h (right):

https://codereview.chromium.org/2912283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.h:227: bool
needs_handle_replaced_element_;
On 2017/05/31 at 07:23:01, yosin_UTC9 wrote:
> nit: Initialize needs_handle_replaced_element_ here instead of ctor.
> 
> Should we have another patch to move member initialization to class decl?

I've added a TODO in the .cpp file that most member initialization should be
moved to class decl. I'll do it with another patch.

[commit-bot: I haz the power, 2017-05-31 18:06:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 19:12:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496253954756810, "parent_rev":
"03dc326e1e32f3262322d1366cd94fbf99826ab5", "commit_rev":
"529b9affa165a95a6b9369809ab26d7c5d37466b"}

[commit-bot: I haz the power, 2017-05-31 19:12:55]

Description was changed from

==========
Use remembered progress to handle replaced elements in TextIterator

This patch utilizes the "remembered progress" mechanism in TextIterator
to handle a replaced element when it emits multiple text runs. In this
way, the control flow becomes cleaner as we don't need to go into the
mail loop of TextIterator::Advance() again.

Follow-up patches will remove the return value of HandlePlacedElement()
because this patch makes it almost useless.

BUG=721957
TEST=n/a; shouldn't have any behavioral change
==========

to

==========
Use remembered progress to handle replaced elements in TextIterator

This patch utilizes the "remembered progress" mechanism in TextIterator
to handle a replaced element when it emits multiple text runs. In this
way, the control flow becomes cleaner as we don't need to go into the
mail loop of TextIterator::Advance() again.

Follow-up patches will remove the return value of HandlePlacedElement()
because this patch makes it almost useless.

BUG=721957
TEST=n/a; shouldn't have any behavioral change

Review-Url: https://codereview.chromium.org/2912283002
Cr-Commit-Position: refs/heads/master@{#475977}
Committed:
https://chromium.googlesource.com/chromium/src/+/529b9affa165a95a6b9369809ab2...
==========

[commit-bot: I haz the power, 2017-05-31 19:12:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/529b9affa165a95a6b9369809ab2...