Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIterator.h

Issue 2914883002: Change return type of TextIterator::HandleXXX to void (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/iterators/TextIterator.h
diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIterator.h b/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
index 5b3167bf61ec4ed7101d9fadb5f0b927f214e2e5..2b0290b07055071b359a922c1de1cfb5a14620a4 100644
--- a/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
+++ b/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
@@ -135,14 +135,9 @@ class CORE_TEMPLATE_CLASS_EXPORT TextIteratorAlgorithm {
// Returns true if text is emitted from the remembered progress (if any).
bool HandleRememberedProgress();
- // Return true if the iteration progress should advance to |kHandledNode|
- // after calling a |HandleXXX| function.
- // TODO(xiaochengh): The meaning of the return values is unclear, and they do
- // not always clearly control the iteration progress. Should consider removing
- // the return values and control the iteration in a cleaner way.
- bool HandleTextNode();
- bool HandleReplacedElement();
- bool HandleNonTextNode();
+ void HandleTextNode();
+ void HandleReplacedElement();
+ void HandleNonTextNode();
void SpliceBuffer(UChar,
Node* text_node,
Node* offset_base_node,

Powered by Google App Engine
This is Rietveld 408576698