third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h - Issue 2914883002: Change return type of TextIterator::HandleXXX to void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h

Issue 2914883002: Change return type of TextIterator::HandleXXX to void (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp ('K') | « third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp » ('j') | third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h

index dc794df760bb3d09f8286e791ac835465702d3e7..adcd9ec1205e15802da3fca112f5ec89e8a9f3e3 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h

+++ b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h

@@ -45,9 +45,7 @@ class TextIteratorTextNodeHandler final {

void ResetCollapsedWhiteSpaceFixup();

- // TODO(xiaochengh): Make the return type |void|. The current return value is

- // not very meaningful.

- bool HandleTextNode(Text*);

+ void HandleTextNode(Text*);

private:

void HandlePreFormattedTextNode();