Automated test case for crbug.com/687863.

ios/chrome/browser/web/window_open_by_dom_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <EarlGrey/EarlGrey.h>
 
 #include "base/format_macros.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 182 matching lines @@
   TapWebViewElementWithId("webScenarioWindowOpenWithPreventDefaultLink");
   AssertMainTabCount(2);
 
   // Ensure that the starting tab hasn't navigated.
   chrome_test_util::CloseCurrentTab();
   const GURL URL = HttpServer::MakeUrl(kTestURL);
   [[EarlGrey selectElementWithMatcher:OmniboxText(URL.GetContent())]
       assertWithMatcher:grey_notNil()];
 }
 
+// Tests opening a child window using the following link
+// <a href="data:text/html,<script>window.location='about:newtab';</script>"
+//    target="_blank">

[baxley, 2017/06/01 21:15:02]

Is this comment too descriptive? Would it be better just to say what it's
attempting to test?

I think the bigger problem is the indirection of having entire test cases in the
html makes it hard to keep things synchronized. Maybe a case of tests that were
written for writeability, rather than readability? I don't expect you to change
anything about the test structure, more just wanted your input.

[Eugene But (OOO till 7-30), 2017/06/01 23:24:57]

I agree it would be better if these tests used inline HTML, but it is what it is
:(. I wanted to be very specific in the comments, because I don't want people
look into html to figure out what this test does. Do you have any concrete
language in mind to use for comments?

[baxley, 2017/06/01 23:40:15]

No. Anything I suggest would make it less concrete, so may as well leave it as
is.

+// TODO(crbug.com/687863): Enable this test.
+- (void)DISABLED_testWindowOpenWithAboutNewTabScript {
+  TapWebViewElementWithId("webScenarioWindowOpenWithAboutNewTabScript");
+  AssertMainTabCount(2);
+  [[EarlGrey selectElementWithMatcher:OmniboxText("about:newtab")]
+      assertWithMatcher:grey_notNil()];
+}
+
 // Tests that closing the current window using DOM fails.
 - (void)testCloseWindowNotOpenByDOM {
   TapWebViewElementWithId("webScenarioWindowClose");
   AssertMainTabCount(1);
 }
 
 // Tests that popup blocking works when a popup is injected into a window before
 // its initial load is committed.
 - (void)testBlockPopupInjectedIntoOpenedWindow {
   chrome_test_util::SetContentSettingsBlockPopups(CONTENT_SETTING_BLOCK);
   TapWebViewElementWithId("webScenarioOpenWindowAndInjectPopup");
   NSString* infobarText = GetBlockedPopupInfobarText(1);
   [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(infobarText)]
       assertWithMatcher:grey_notNil()];
   AssertMainTabCount(2);
 }
 
 @end