Automated test case for crbug.com/687863.

ios/chrome/browser/web/window_open_by_dom_egtest.mm

Index: ios/chrome/browser/web/window_open_by_dom_egtest.mm
diff --git a/ios/chrome/browser/web/window_open_by_dom_egtest.mm b/ios/chrome/browser/web/window_open_by_dom_egtest.mm
index 077be28f1b4a967db8cf13c66b1f09fe081429ab..631be43519c5907f3feaaa69e71f93c06530ff31 100644
--- a/ios/chrome/browser/web/window_open_by_dom_egtest.mm
+++ b/ios/chrome/browser/web/window_open_by_dom_egtest.mm
@@ -200,6 +200,17 @@ NSString* GetBlockedPopupInfobarText(size_t blocked_count) {
       assertWithMatcher:grey_notNil()];
 }
 
+// Tests opening a child window using the following link
+// <a href="data:text/html,<script>window.location='about:newtab';</script>"
+//    target="_blank">

[baxley, 2017/06/01 21:15:02]

Is this comment too descriptive? Would it be better just to say what it's
attempting to test?

I think the bigger problem is the indirection of having entire test cases in the
html makes it hard to keep things synchronized. Maybe a case of tests that were
written for writeability, rather than readability? I don't expect you to change
anything about the test structure, more just wanted your input.

[Eugene But (OOO till 7-30), 2017/06/01 23:24:57]

I agree it would be better if these tests used inline HTML, but it is what it is
:(. I wanted to be very specific in the comments, because I don't want people
look into html to figure out what this test does. Do you have any concrete
language in mind to use for comments?

[baxley, 2017/06/01 23:40:15]

No. Anything I suggest would make it less concrete, so may as well leave it as
is.

+// TODO(crbug.com/687863): Enable this test.
+- (void)DISABLED_testWindowOpenWithAboutNewTabScript {
+  TapWebViewElementWithId("webScenarioWindowOpenWithAboutNewTabScript");
+  AssertMainTabCount(2);
+  [[EarlGrey selectElementWithMatcher:OmniboxText("about:newtab")]
+      assertWithMatcher:grey_notNil()];
+}
+
 // Tests that closing the current window using DOM fails.
 - (void)testCloseWindowNotOpenByDOM {
   TapWebViewElementWithId("webScenarioWindowClose");