Implementation of translation event logging.

Implementation of translation event logging.

Integration steps described in:

https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_D8/edit#heading=h.qdctas2f6c6e

BUG=728491
Review-Url: https://codereview.chromium.org/2913593002
Cr-Commit-Position: refs/heads/master@{#479219}
Committed: https://chromium.googlesource.com/chromium/src/+/23fe0e721faec0123be8c521e377ff22c7fefe88

[renjieliu1, 2017-05-29 06:59:20]

Description was changed from

==========
Implementation of translation event logging.

BUG=
==========

to

==========
Implementation of translation event logging.

BUG=
==========

[renjieliu1, 2017-05-29 06:59:20]

renjieliu@chromium.org changed reviewers:
+ napper@chromium.org

[renjieliu1, 2017-05-29 07:00:57]

initial cl of translation event client side logging. I will add a unit test
later.

[renjieliu1, 2017-05-29 07:01:16]

The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 07:01:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 07:10:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 07:10:53]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[renjieliu1, 2017-05-30 00:11:26]

The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 00:11:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 00:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 00:22:25]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[renjieliu1, 2017-05-30 01:29:18]

The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 01:29:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 02:27:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 02:27:41]

Dry run: This issue passed the CQ dry run.

[renjieliu1, 2017-05-30 02:42:32]

fixed the tap, PTAL. Thanks!

[napper, 2017-05-30 02:56:26]

napper@chromium.org changed reviewers:
+ amoylan@chromium.org

[napper, 2017-05-30 02:56:26]

https://codereview.chromium.org/2913593002/diff/40001/chrome/browser/translat...
File chrome/browser/translate/chrome_translate_client.cc (right):

https://codereview.chromium.org/2913593002/diff/40001/chrome/browser/translat...
chrome/browser/translate/chrome_translate_client.cc:151: case
TranslateEventProto::USER_DECLINE:
I think we should keep the naming consistent (i.e. change REJECTED to DECLINE).

[amoylan, 2017-05-30 03:10:56]

https://codereview.chromium.org/2913593002/diff/40001/chrome/browser/translat...
File chrome/browser/translate/chrome_translate_client.cc (right):

https://codereview.chromium.org/2913593002/diff/40001/chrome/browser/translat...
chrome/browser/translate/chrome_translate_client.cc:121: bool
ConstructTranslateEvent(const int entry_id,
Can we add a comment atop this function? particularly, what does it return.

https://codereview.chromium.org/2913593002/diff/40001/chrome/browser/translat...
chrome/browser/translate/chrome_translate_client.cc:174: auto* const profile =
Do you want to DCHECK web_contents != nullptr?
Actually it seems like this could take a const WebContents& instead of a pointer
if you like.

https://codereview.chromium.org/2913593002/diff/40001/components/translate/co...
File components/translate/core/browser/translate_client.h (right):

https://codereview.chromium.org/2913593002/diff/40001/components/translate/co...
components/translate/core/browser/translate_client.h:58: // This is for
gaia-keyed logging.
Is 'gaia' the right terminology to use in the context of a Chromium
//components?

https://codereview.chromium.org/2913593002/diff/40001/components/translate/co...
components/translate/core/browser/translate_client.h:59: virtual void
RecordTranslateEvent(const metrics::TranslateEventProto&) = 0;
Include name of the parameter to RecordTranslateEvent in this declaration, since
this parameter is not an unused parameter.

[renjieliu1, 2017-05-30 03:33:24]

https://codereview.chromium.org/2913593002/diff/40001/chrome/browser/translat...
File chrome/browser/translate/chrome_translate_client.cc (right):

https://codereview.chromium.org/2913593002/diff/40001/chrome/browser/translat...
chrome/browser/translate/chrome_translate_client.cc:121: bool
ConstructTranslateEvent(const int entry_id,
On 2017/05/30 03:10:56, amoylan wrote:
> Can we add a comment atop this function? particularly, what does it return.

Done.

https://codereview.chromium.org/2913593002/diff/40001/chrome/browser/translat...
chrome/browser/translate/chrome_translate_client.cc:151: case
TranslateEventProto::USER_DECLINE:
On 2017/05/30 02:56:26, napper wrote:
> I think we should keep the naming consistent (i.e. change REJECTED to
DECLINE).

Done. Changed the proto as well.

https://codereview.chromium.org/2913593002/diff/40001/chrome/browser/translat...
chrome/browser/translate/chrome_translate_client.cc:174: auto* const profile =
On 2017/05/30 03:10:56, amoylan wrote:
> Do you want to DCHECK web_contents != nullptr?
> Actually it seems like this could take a const WebContents& instead of a
pointer
> if you like.

Done.

https://codereview.chromium.org/2913593002/diff/40001/components/translate/co...
File components/translate/core/browser/translate_client.h (right):

https://codereview.chromium.org/2913593002/diff/40001/components/translate/co...
components/translate/core/browser/translate_client.h:58: // This is for
gaia-keyed logging.
On 2017/05/30 03:10:56, amoylan wrote:
> Is 'gaia' the right terminology to use in the context of a Chromium
> //components?

thanks for pointing out this!

https://codereview.chromium.org/2913593002/diff/40001/components/translate/co...
components/translate/core/browser/translate_client.h:59: virtual void
RecordTranslateEvent(const metrics::TranslateEventProto&) = 0;
On 2017/05/30 03:10:56, amoylan wrote:
> Include name of the parameter to RecordTranslateEvent in this declaration,
since
> this parameter is not an unused parameter.

Done.

[renjieliu1, 2017-05-31 02:54:19]

Refactoring the code to put construct proto part at
components/translate/core/common so the code can be
shared with iOS part as well.

[renjieliu1, 2017-05-31 02:54:33]

The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 02:54:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 02:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 02:57:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[renjieliu1, 2017-05-31 03:03:33]

The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 03:04:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 04:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 04:37:53]

Dry run: This issue passed the CQ dry run.

[napper, 2017-05-31 04:49:56]

lgtm

https://codereview.chromium.org/2913593002/diff/120001/components/translate/c...
File components/translate/core/common/translation_logging_helper.cc (right):

https://codereview.chromium.org/2913593002/diff/120001/components/translate/c...
components/translate/core/common/translation_logging_helper.cc:45:
translation->set_interaction(sync_pb::Translation::MANUAL);
Why do we need MANUAL? Don't you know it is manual if
!modified_source_language().empty() or !modified_target_language().empty()

[renjieliu1, 2017-05-31 05:22:32]

thanks for the review!

https://codereview.chromium.org/2913593002/diff/120001/components/translate/c...
File components/translate/core/common/translation_logging_helper.cc (right):

https://codereview.chromium.org/2913593002/diff/120001/components/translate/c...
components/translate/core/common/translation_logging_helper.cc:45:
translation->set_interaction(sync_pb::Translation::MANUAL);
On 2017/05/31 04:49:56, napper wrote:
> Why do we need MANUAL? Don't you know it is manual if
> !modified_source_language().empty() or !modified_target_language().empty()

currently in our proto
(https://codereview.chromium.org/2911603002/patch/60001/70004) we don't have
modified_source_language and modified_target_language fields, do we need to
record that as well?

[napper, 2017-05-31 05:28:42]

On 2017/05/31 at 05:22:32, renjieliu wrote:
> thanks for the review!
> 
>
https://codereview.chromium.org/2913593002/diff/120001/components/translate/c...
> File components/translate/core/common/translation_logging_helper.cc (right):
> 
>
https://codereview.chromium.org/2913593002/diff/120001/components/translate/c...
> components/translate/core/common/translation_logging_helper.cc:45:
translation->set_interaction(sync_pb::Translation::MANUAL);
> On 2017/05/31 04:49:56, napper wrote:
> > Why do we need MANUAL? Don't you know it is manual if
> > !modified_source_language().empty() or !modified_target_language().empty()
> 
> currently in our proto
(https://codereview.chromium.org/2911603002/patch/60001/70004) we don't have
modified_source_language and modified_target_language fields, do we need to
record that as well?

Ahhh okay. No I think this is fine then.

[renjieliu1, 2017-06-01 05:27:52]

Description was changed from

==========
Implementation of translation event logging.

BUG=
==========

to

==========
Implementation of translation event logging.

Integration steps described in:

https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_...

BUG=728491
==========

[renjieliu1, 2017-06-01 05:27:52]

renjieliu@chromium.org changed reviewers:
+ groby@chromium.org

[renjieliu1, 2017-06-01 05:31:39]

Hi Rachel,

We're implementing client side gaia-keyed logging for translation event.

I will implement the same logic for iOS next, and I will corresponding unit test
for Sync logic once https://codereview.chromium.org/2909283003/ is landed.

PTAL.

Thanks a lot!

[groby-ooo-7-16, 2017-06-01 14:03:42]

Will take a look soon - in the meantime, gaia-keyed logging is probably
something privacy should be involved in, if you haven't already looped them
in. (The docs/bugs weren't clear if you already did, so sorry if this is
just repeating something you already know/have done)

On Wed, May 31, 2017 at 10:31 PM, <renjieliu@chromium.org> wrote:

> Hi Rachel,
>
> We're implementing client side gaia-keyed logging for translation event.
>
> I will implement the same logic for iOS next, and I will corresponding
> unit test
> for Sync logic once https://codereview.chromium.org/2909283003/ is landed.
>
> PTAL.
>
> Thanks a lot!
>
> https://codereview.chromium.org/2913593002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-06-01 23:14:55]

Thanks Rachel, logging is obviously very privacy sensitive, and we have
been talking to Chrome privacy about it. There will be a full privacy
review (including a logs launch privacy review) prior to launch as part of
the launch process (our launch cal is
https://ariane.googleplex.com/search?query=193016&show=all).


On Fri, 2 Jun 2017 at 00:03 Rachel Blum <groby@chromium.org> wrote:

> Will take a look soon - in the meantime, gaia-keyed logging is probably
> something privacy should be involved in, if you haven't already looped them
> in. (The docs/bugs weren't clear if you already did, so sorry if this is
> just repeating something you already know/have done)
>
> On Wed, May 31, 2017 at 10:31 PM, <renjieliu@chromium.org> wrote:
>
>> Hi Rachel,
>>
>> We're implementing client side gaia-keyed logging for translation event.
>>
>> I will implement the same logic for iOS next, and I will corresponding
>> unit test
>> for Sync logic once https://codereview.chromium.org/2909283003/ is
>> landed.
>>
>> PTAL.
>>
>> Thanks a lot!
>>
>> https://codereview.chromium.org/2913593002/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[renjieliu1, 2017-06-06 00:54:16]

Hi Rachel,

Friendly ping, any updates on the cl?

Thank you! :D

[groby-ooo-7-16, 2017-06-07 16:53:49]

On 2017/06/06 00:54:16, renjieliu1 wrote:
> Hi Rachel,
> 
> Friendly ping, any updates on the cl?
> 
> Thank you! :D

Shouldn't this be gated behind a flag if this is pending a privacy review?

(If that is addressed elsewhere, LGTM)

[groby-ooo-7-16, 2017-06-07 16:53:50]

On 2017/06/06 00:54:16, renjieliu1 wrote:
> Hi Rachel,
> 
> Friendly ping, any updates on the cl?
> 
> Thank you! :D

Shouldn't this be gated behind a flag if this is pending a privacy review?

(If that is addressed elsewhere, LGTM)

[napper, 2017-06-07 17:13:52]

On 2017/06/07 at 16:53:50, groby wrote:
> On 2017/06/06 00:54:16, renjieliu1 wrote:
> > Hi Rachel,
> > 
> > Friendly ping, any updates on the cl?
> > 
> > Thank you! :D
> 
> Shouldn't this be gated behind a flag if this is pending a privacy review?
> 
> (If that is addressed elsewhere, LGTM)

From skym@:
"The UserEventService currently contains a finch flag check that's going to
disable recording any data before we get launch approval. This means that
integration points can just start blindly writing events (assuming it isn't
computationally expensive to create your event)."

[groby-ooo-7-16, 2017-06-07 18:11:49]

On 2017/06/07 17:13:52, napper wrote:
> On 2017/06/07 at 16:53:50, groby wrote:
> > On 2017/06/06 00:54:16, renjieliu1 wrote:
> > > Hi Rachel,
> > > 
> > > Friendly ping, any updates on the cl?
> > > 
> > > Thank you! :D
> > 
> > Shouldn't this be gated behind a flag if this is pending a privacy review?
> > 
> > (If that is addressed elsewhere, LGTM)
> 
> From skym@:
> "The UserEventService currently contains a finch flag check that's going to
> disable recording any data before we get launch approval. This means that
> integration points can just start blindly writing events (assuming it isn't
> computationally expensive to create your event)."

Isn't your logging *also* gated on privacy approval? (Even if it is, you could
probably land this and just follow up with a flag)

[napper, 2017-06-07 19:35:48]

On 2017/06/07 at 18:11:49, groby wrote:
> On 2017/06/07 17:13:52, napper wrote:
> > On 2017/06/07 at 16:53:50, groby wrote:
> > > On 2017/06/06 00:54:16, renjieliu1 wrote:
> > > > Hi Rachel,
> > > > 
> > > > Friendly ping, any updates on the cl?
> > > > 
> > > > Thank you! :D
> > > 
> > > Shouldn't this be gated behind a flag if this is pending a privacy review?
> > > 
> > > (If that is addressed elsewhere, LGTM)
> > 
> > From skym@:
> > "The UserEventService currently contains a finch flag check that's going to
> > disable recording any data before we get launch approval. This means that
> > integration points can just start blindly writing events (assuming it isn't
> > computationally expensive to create your event)."
> 
> Isn't your logging *also* gated on privacy approval? (Even if it is, you could
probably land this and just follow up with a flag)

Yes, good point. We shouldn't rely on the general logging flag. Renjie, can you
create a seperate flag for the translation logging events?

[renjieliu1, 2017-06-08 00:49:33]

On 2017/06/07 19:35:48, napper wrote:
> On 2017/06/07 at 18:11:49, groby wrote:
> > On 2017/06/07 17:13:52, napper wrote:
> > > On 2017/06/07 at 16:53:50, groby wrote:
> > > > On 2017/06/06 00:54:16, renjieliu1 wrote:
> > > > > Hi Rachel,
> > > > > 
> > > > > Friendly ping, any updates on the cl?
> > > > > 
> > > > > Thank you! :D
> > > > 
> > > > Shouldn't this be gated behind a flag if this is pending a privacy
review?
> > > > 
> > > > (If that is addressed elsewhere, LGTM)
> > > 
> > > From skym@:
> > > "The UserEventService currently contains a finch flag check that's going
to
> > > disable recording any data before we get launch approval. This means that
> > > integration points can just start blindly writing events (assuming it
isn't
> > > computationally expensive to create your event)."
> > 
> > Isn't your logging *also* gated on privacy approval? (Even if it is, you
could
> probably land this and just follow up with a flag)
> 
> Yes, good point. We shouldn't rely on the general logging flag. Renjie, can
you
> create a seperate flag for the translation logging events?

I added two switches in this cl: https://codereview.chromium.org/2932603002/

I'm not sure where to put the switches, so I put the switches next to skym@
flags as it's clearer.

WDYT? Thanks!

[renjieliu1, 2017-06-08 04:30:11]

thanks for the review, I changed the navigation id as skym@ suggested. I will
put the logging logic behind the switch as
https://codereview.chromium.org/2932603002/ landed.

[renjieliu1, 2017-06-08 04:41:49]

renjieliu@chromium.org changed reviewers:
+ eugenebut@chromium.org

[renjieliu1, 2017-06-08 04:41:50]

eugenebut@chromium.org: Please review changes in 

ios/web/view_internal/translate

Thanks a lot!

[Eugene But (OOO till 7-30), 2017-06-12 01:50:00]

ios lgtm

https://codereview.chromium.org/2913593002/diff/200001/ios/chrome/browser/tra...
File ios/chrome/browser/translate/chrome_ios_translate_client.mm (right):

https://codereview.chromium.org/2913593002/diff/200001/ios/chrome/browser/tra...
ios/chrome/browser/translate/chrome_ios_translate_client.mm:106: //
TODO(renjieliu): Implementing gaia-keyed logging.
In ios we normally use |TODO(crbug.com/<bug number>):| format, because people
leave but bugs stay.

https://codereview.chromium.org/2913593002/diff/200001/ios/web_view/internal/...
File ios/web_view/internal/translate/web_view_translate_client.mm (right):

https://codereview.chromium.org/2913593002/diff/200001/ios/web_view/internal/...
ios/web_view/internal/translate/web_view_translate_client.mm:117: //
TODO(renjieliu): Implementing gaia-keyed logging.
ditto

[renjieliu1, 2017-06-13 00:04:59]

thanks for the review!

https://codereview.chromium.org/2913593002/diff/200001/ios/chrome/browser/tra...
File ios/chrome/browser/translate/chrome_ios_translate_client.mm (right):

https://codereview.chromium.org/2913593002/diff/200001/ios/chrome/browser/tra...
ios/chrome/browser/translate/chrome_ios_translate_client.mm:106: //
TODO(renjieliu): Implementing gaia-keyed logging.
On 2017/06/12 01:50:00, Eugene But (OOO till June 11) wrote:
> In ios we normally use |TODO(crbug.com/<bug number>):| format, because people
> leave but bugs stay.

got it, thanks!

https://codereview.chromium.org/2913593002/diff/200001/ios/web_view/internal/...
File ios/web_view/internal/translate/web_view_translate_client.mm (right):

https://codereview.chromium.org/2913593002/diff/200001/ios/web_view/internal/...
ios/web_view/internal/translate/web_view_translate_client.mm:117: //
TODO(renjieliu): Implementing gaia-keyed logging.
On 2017/06/12 01:50:00, Eugene But (OOO till June 11) wrote:
> ditto

Done.

[renjieliu1, 2017-06-13 00:05:53]

The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 00:06:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 00:51:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 00:51:41]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[renjieliu1, 2017-06-13 01:16:38]

The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 01:16:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 03:40:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 03:40:27]

Dry run: This issue passed the CQ dry run.

[renjieliu1, 2017-06-13 03:40:49]

The CQ bit was checked by renjieliu@chromium.org

[renjieliu1, 2017-06-13 03:40:50]

The patchset sent to the CQ was uploaded after l-g-t-m from napper@chromium.org,
groby@chromium.org, eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2913593002/#ps240001
(title: "fix")

[commit-bot: I haz the power, 2017-06-13 03:41:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[renjieliu1, 2017-06-13 03:48:46]

renjieliu@chromium.org changed reviewers:
+ holte@chromium.org

[renjieliu1, 2017-06-13 03:48:47]

Hi Steven, Can you review the change in DEPS file for adding
components/metrics/proto? thanks a lot!

[commit-bot: I haz the power, 2017-06-13 03:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 03:50:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Steven Holte, 2017-06-13 19:52:19]

DEPS on metrics proto for translate event lgtm

[renjieliu1, 2017-06-14 00:04:24]

The CQ bit was checked by renjieliu@chromium.org

[commit-bot: I haz the power, 2017-06-14 00:04:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 00:10:47]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1497398664997440,
"parent_rev": "ffb480444a84adb2b3b983c6934d3fd76f4bd223", "commit_rev":
"23fe0e721faec0123be8c521e377ff22c7fefe88"}

[commit-bot: I haz the power, 2017-06-14 00:11:03]

Description was changed from

==========
Implementation of translation event logging.

Integration steps described in:

https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_...

BUG=728491
==========

to

==========
Implementation of translation event logging.

Integration steps described in:

https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_...

BUG=728491

Review-Url: https://codereview.chromium.org/2913593002
Cr-Commit-Position: refs/heads/master@{#479219}
Committed:
https://chromium.googlesource.com/chromium/src/+/23fe0e721faec0123be8c521e377...
==========

[commit-bot: I haz the power, 2017-06-14 00:11:04]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/23fe0e721faec0123be8c521e377...