Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/translate/chrome_ios_translate_client.mm

Issue 2913593002: Implementation of translation event logging. (Closed)
Patch Set: fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/translate/chrome_ios_translate_client.mm
diff --git a/ios/chrome/browser/translate/chrome_ios_translate_client.mm b/ios/chrome/browser/translate/chrome_ios_translate_client.mm
index b474a2808e9824d21771cc77688f152b2f04b04e..b374335e73ff7fc02f891cfdc6bc2f9469e703aa 100644
--- a/ios/chrome/browser/translate/chrome_ios_translate_client.mm
+++ b/ios/chrome/browser/translate/chrome_ios_translate_client.mm
@@ -10,6 +10,7 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "components/infobars/core/infobar.h"
+#include "components/metrics/proto/translate_event.pb.h"
#include "components/prefs/pref_service.h"
#include "components/translate/core/browser/page_translated_details.h"
#include "components/translate/core/browser/translate_accept_languages.h"
@@ -100,6 +101,11 @@ std::unique_ptr<infobars::InfoBar> ChromeIOSTranslateClient::CreateInfoBar(
return std::move(infobar);
}
+void ChromeIOSTranslateClient::RecordTranslateEvent(
+ const metrics::TranslateEventProto&) {
+ // TODO(crbug.com/728491): Implementing gaia-keyed logging.
+}
+
void ChromeIOSTranslateClient::ShowTranslateUI(
translate::TranslateStep step,
const std::string& source_language,

Powered by Google App Engine
This is Rietveld 408576698