Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2932603002: Set up switches for user language detection and translation events. (Closed)

Created:
3 years, 6 months ago by renjieliu1
Modified:
3 years, 6 months ago
Reviewers:
napper, skym, groby-ooo-7-16
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set up switches for user language detection and translation events. These two switches control logging language detection and translation events behavior. However, we still rely on SyncUserEvents as a centralized gateway to logging. BUG=722679, 728491 Review-Url: https://codereview.chromium.org/2932603002 Cr-Commit-Position: refs/heads/master@{#479247} Committed: https://chromium.googlesource.com/chromium/src/+/cdce2652bc147496e6d53348d80f21c8d7e7dec6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M components/sync/driver/sync_driver_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync/driver/sync_driver_switches.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
renjieliu1
3 years, 6 months ago (2017-06-08 00:48:18 UTC) #5
napper
lgtm but note we are planning to only have a single launch (i.e., both detection ...
3 years, 6 months ago (2017-06-09 17:38:33 UTC) #8
renjieliu1
On 2017/06/09 17:38:33, napper wrote: > lgtm but note we are planning to only have ...
3 years, 6 months ago (2017-06-12 23:46:36 UTC) #9
renjieliu1
3 years, 6 months ago (2017-06-13 00:07:04 UTC) #11
groby-ooo-7-16
lgtm
3 years, 6 months ago (2017-06-13 00:28:15 UTC) #12
skym
lgtm
3 years, 6 months ago (2017-06-13 18:44:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932603002/1
3 years, 6 months ago (2017-06-14 00:18:30 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 01:41:43 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cdce2652bc147496e6d53348d80f...

Powered by Google App Engine
This is Rietveld 408576698