components/translate/core/browser/translate_manager.cc - Issue 2913593002: Implementation of translation event logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_manager.cc

Issue 2913593002: Implementation of translation event logging. (Closed)

Patch Set: fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/browser/translate_manager.cc

diff --git a/components/translate/core/browser/translate_manager.cc b/components/translate/core/browser/translate_manager.cc

index 089c6137cd1d00eda469fa923184ecb86f2ba540..0da0e8c0c2d3d31b33b02ab9a57899abcf3d3de7 100644

--- a/components/translate/core/browser/translate_manager.cc

+++ b/components/translate/core/browser/translate_manager.cc

@@ -572,6 +572,7 @@ void TranslateManager::InitTranslateEvent(const std::string& src_lang,

void TranslateManager::RecordTranslateEvent(int event_type) {

translate_ranker_->RecordTranslateEvent(

event_type, translate_driver_->GetVisibleURL(), translate_event_.get());

+ translate_client_->RecordTranslateEvent(*translate_event_.get());

}

bool TranslateManager::ShouldOverrideDecision(int event_type) {