Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2912663002: Clean up creation of "detached" SVG* data type objects (Closed)

Created:
3 years, 6 months ago by fs
Modified:
3 years, 6 months ago
Reviewers:
Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up creation of "detached" SVG* data type objects Add CreateDetached helpers for the various objects (or, their tear-offs) that can be created without having a context element. This is in preparation for replacing some of these with their DOM* counterparts from the Geometry specifications [1]. The "detached" term is borrowed from the SVG2 specification [2]. Also drop all of the default arguments that pass QualifiedName::Null(), and instead explicitly pass them where needed (for detached objects.) [1] https://drafts.fxtf.org/geometry/ [2] https://svgwg.org/svg2-draft/struct.html#__svg__SVGSVGElement__createSVGNumber BUG=709001 Review-Url: https://codereview.chromium.org/2912663002 Cr-Commit-Position: refs/heads/master@{#475583} Committed: https://chromium.googlesource.com/chromium/src/+/99b481419897f642644932ecab1db0ee7453147e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -92 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAngleTearOff.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthTearOff.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberListTearOff.h View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberTearOff.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointListTearOff.h View 2 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointTearOff.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointTearOff.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatioTearOff.h View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRectTearOff.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRectTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 3 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStringListTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformListTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformTearOff.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformTearOff.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.h View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 6 months ago (2017-05-29 18:11:24 UTC) #7
Stephen Chennney
lgtm
3 years, 6 months ago (2017-05-30 15:24:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912663002/1
3 years, 6 months ago (2017-05-30 15:26:43 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 17:42:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99b481419897f642644932ecab1d...

Powered by Google App Engine
This is Rietveld 408576698