third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp - Issue 2912663002: Clean up creation of "detached" SVG* data type objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp

Issue 2912663002: Clean up creation of "detached" SVG* data type objects (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp b/third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp

index d8cb10c70448ea5ceeeb1b980691d543cfa809eb..02665ba9b5c30ebe69eebcc9bc97e558b8c4462c 100644

--- a/third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp

@@ -173,8 +173,7 @@ SVGRectTearOff* SVGGraphicsElement::getBBoxFromJavascript() {

FloatRect boundingBox;

if (GetLayoutObject())

boundingBox = GetBBox();

- return SVGRectTearOff::Create(SVGRect::Create(boundingBox), 0,

- kPropertyIsNotAnimVal);

+ return SVGRectTearOff::CreateDetached(boundingBox);

}

} // namespace blink