third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp - Issue 2912663002: Clean up creation of "detached" SVG* data type objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp

Issue 2912663002: Clean up creation of "detached" SVG* data type objects (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp b/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp

index 041195d9fea831d10417cd561cfb125ed88256c0..eda675c174c2c5d8b247a5ff3d0e0791562d9f3c 100644

--- a/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp

@@ -130,8 +130,7 @@ SVGPointTearOff* SVGGeometryElement::getPointAtLength(float length) {

FloatPoint point;

if (GetLayoutObject())

point = AsPath().PointAtLength(length);

- return SVGPointTearOff::Create(SVGPoint::Create(point), 0,

- kPropertyIsNotAnimVal);

+ return SVGPointTearOff::CreateDetached(point);

}

float SVGGeometryElement::ComputePathLength() const {