third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp - Issue 2912663002: Clean up creation of "detached" SVG* data type objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp

Issue 2912663002: Clean up creation of "detached" SVG* data type objects (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp b/third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp

index f7784a156778331fb77eb7e219eb0c743d1b6489..928139de9114ce6c61c1f05dabb32907c06e1041 100644

--- a/third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp

@@ -129,6 +129,11 @@ void SVGAngleTearOff::setValueAsString(const String& value,

CommitChange();

}

+SVGAngleTearOff* SVGAngleTearOff::CreateDetached() {

+ return Create(SVGAngle::Create(), nullptr, kPropertyIsNotAnimVal,

+ QualifiedName::Null());

DEFINE_TRACE_WRAPPERS(SVGAngleTearOff) {

visitor->TraceWrappers(contextElement());

}