Make check_gn_headers.py more robust on the bots

Make check_gn_headers.py more robust on the bots

Check whether the build is dirty first, and abort when dirty. This can
be skipped by using option --skip-dirty-check.

Dump JSON output on error, so that the result is still valid.

Filter out generated headers more aggressively.

Report non-existing headers in JSON as well.

BUG=725877
Review-Url: https://codereview.chromium.org/2911543002
Cr-Commit-Position: refs/heads/master@{#476895}
Committed: https://chromium.googlesource.com/chromium/src/+/0735fd76fd89d25935fd27d1d985ca0f3457a18a

[wychen, 2017-05-25 23:05:25]

wychen@chromium.org changed reviewers:
+ dpranke@chromium.org

[wychen, 2017-05-25 23:05:25]

PTAL.

Per https://crbug.com/725877#c14, I'd like to gather more data, specifically
'Found non-existing files in ninja deps' even after build all.

If the script returns non-zero, and also dump the JSON file, the bot would try
again without the patch, and if the JSON output remains the same, it wouldn't
fail the run, right?

In the recent builds page, that entry would still show up as green, and has a
summary like the one below, right?
 
Build successful failed check_gn_header (with patch) failed check_gn_header
(without patch)

[wychen, 2017-05-26 07:27:59]

Patchset #5 (id:80001) has been deleted

[wychen, 2017-05-31 19:41:31]

Description was changed from

==========
Make check_gn_headers.py more robust on the bots

Check whether the build is dirty first, and abort when dirty. This can
be skipped by using option --skip-dirty-check.

Dump JSON output on error, so that the result is still valid.

BUG=725877
==========

to

==========
Make check_gn_headers.py more robust on the bots

Check whether the build is dirty first, and abort when dirty. This can
be skipped by using option --skip-dirty-check.

Dump JSON output on error, so that the result is still valid.

Filter out generated headers more aggressively.

BUG=725877
==========

[wychen, 2017-05-31 19:43:28]

Description was changed from

==========
Make check_gn_headers.py more robust on the bots

Check whether the build is dirty first, and abort when dirty. This can
be skipped by using option --skip-dirty-check.

Dump JSON output on error, so that the result is still valid.

Filter out generated headers more aggressively.

BUG=725877
==========

to

==========
Make check_gn_headers.py more robust on the bots

Check whether the build is dirty first, and abort when dirty. This can
be skipped by using option --skip-dirty-check.

Dump JSON output on error, so that the result is still valid.

Filter out generated headers more aggressively.

Report non-existing headers in JSON as well.

BUG=725877
==========

[Dirk Pranke, 2017-06-03 01:16:37]

lgtm

https://codereview.chromium.org/2911543002/diff/100001/build/check_gn_headers.py
File build/check_gn_headers.py (right):

https://codereview.chromium.org/2911543002/diff/100001/build/check_gn_headers...
build/check_gn_headers.py:226: PrintError(d_err)
I'd pass the parser into PrintError; relying on the enclosed lexical scope is a
little dodgy in Python and it's not really necessary here.

[wychen, 2017-06-03 07:37:37]

Thanks for your review!

https://codereview.chromium.org/2911543002/diff/100001/build/check_gn_headers.py
File build/check_gn_headers.py (right):

https://codereview.chromium.org/2911543002/diff/100001/build/check_gn_headers...
build/check_gn_headers.py:226: PrintError(d_err)
On 2017/06/03 01:16:37, Dirk Pranke (slow) wrote:
> I'd pass the parser into PrintError; relying on the enclosed lexical scope is
a
> little dodgy in Python and it's not really necessary here.

It requires more than just |parser|. It also needs to conditionally dump an
empty json file, so args.json is also needed. Then it feels a bit repetitive.

I'll land this as is for now. If you think passing these looks better, I'm more
than happy to fix it in a following CL.

[wychen, 2017-06-03 07:39:55]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2017-06-03 07:40:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 07:53:29]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496475595146850,
"parent_rev": "2eff7cfefdef090f2d7190dccd55dcc467601cea", "commit_rev":
"0735fd76fd89d25935fd27d1d985ca0f3457a18a"}

[commit-bot: I haz the power, 2017-06-03 07:53:42]

Description was changed from

==========
Make check_gn_headers.py more robust on the bots

Check whether the build is dirty first, and abort when dirty. This can
be skipped by using option --skip-dirty-check.

Dump JSON output on error, so that the result is still valid.

Filter out generated headers more aggressively.

Report non-existing headers in JSON as well.

BUG=725877
==========

to

==========
Make check_gn_headers.py more robust on the bots

Check whether the build is dirty first, and abort when dirty. This can
be skipped by using option --skip-dirty-check.

Dump JSON output on error, so that the result is still valid.

Filter out generated headers more aggressively.

Report non-existing headers in JSON as well.

BUG=725877

Review-Url: https://codereview.chromium.org/2911543002
Cr-Commit-Position: refs/heads/master@{#476895}
Committed:
https://chromium.googlesource.com/chromium/src/+/0735fd76fd89d25935fd27d1d985...
==========

[commit-bot: I haz the power, 2017-06-03 07:53:44]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/0735fd76fd89d25935fd27d1d985...