Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Issue 2903063006: Handle exceptions in check_gn_headers.py (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle exceptions in check_gn_headers.py If exceptions are thrown, the main process would wait forever if they are not handled. This could potentially cause timeout on the bots. BUG=661774 Review-Url: https://codereview.chromium.org/2903063006 Cr-Commit-Position: refs/heads/master@{#474873} Committed: https://chromium.googlesource.com/chromium/src/+/09692cdc03a2723afadf7109b2b8404a9eb497ed

Patch Set 1 #

Patch Set 2 : handle all exceptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M build/check_gn_headers.py View 1 6 chunks +32 lines, -15 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-25 21:03:29 UTC) #2
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-25 22:56:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903063006/20001
3 years, 7 months ago (2017-05-26 00:43:10 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 01:57:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/09692cdc03a2723afadf7109b2b8...

Powered by Google App Engine
This is Rietveld 408576698