Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: build/check_gn_headers_unittest.py

Issue 2911543002: Make check_gn_headers.py more robust on the bots (Closed)
Patch Set: filter out* as well Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/check_gn_headers.py ('K') | « build/check_gn_headers.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/check_gn_headers_unittest.py
diff --git a/build/check_gn_headers_unittest.py b/build/check_gn_headers_unittest.py
index 78c78776a15544cc11e4ebab88727e782926d850..e0853fdefef0c1129387ed96ae625977dcb2cf2e 100755
--- a/build/check_gn_headers_unittest.py
+++ b/build/check_gn_headers_unittest.py
@@ -25,6 +25,7 @@ obj/c.o: #deps 1, deps mtime 123 (VALID)
../../c.cc
../../build/a.h
gen/b.h
+ ../../out/Release/gen/no.h
../../dir3/path/b.h
../../c3.hh
'''
@@ -64,7 +65,8 @@ a/b/c
class CheckGnHeadersTest(unittest.TestCase):
def testNinja(self):
- headers = check_gn_headers.ParseNinjaDepsOutput(ninja_input.split('\n'))
+ headers = check_gn_headers.ParseNinjaDepsOutput(
+ ninja_input.split('\n'), 'out/Release')
expected = set([
'dir/path/b.h',
'c.hh',
@@ -78,7 +80,7 @@ class CheckGnHeadersTest(unittest.TestCase):
os.sep = '\\'
headers = check_gn_headers.ParseNinjaDepsOutput(
- ninja_input_win.split('\n'))
+ ninja_input_win.split('\n'), 'out\\Release')
expected = set([
'dir\\path\\b.h',
'c.hh',
« build/check_gn_headers.py ('K') | « build/check_gn_headers.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698