Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2904073003: Add scripts for running GN missing header checker on CQ (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add scripts for running GN missing header checker on CQ This relands part of crrev.com/2903733004, but not enabled. The enabling config would be landed in a separate CL. BUG=661774, 725877 Review-Url: https://codereview.chromium.org/2904073003 Cr-Commit-Position: refs/heads/master@{#477056} Committed: https://chromium.googlesource.com/chromium/src/+/f7d9e91e64165b26cbfd95d29c33d4d6f0b46126

Patch Set 1 : import crrev.com/2903733004 #

Patch Set 2 : rebase #

Patch Set 3 : rebase, update whitelist #

Patch Set 4 : rebase #

Patch Set 5 : revert testing/buildbot/chromium.linux.json #

Patch Set 6 : update whitelist #

Patch Set 7 : update whitelist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -0 lines) Patch
A build/check_gn_headers_whitelist.txt View 1 2 3 4 5 6 1 chunk +395 lines, -0 lines 0 comments Download
A testing/scripts/check_gn_headers.py View 1 chunk +46 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
wychen
PTAL. I've split the previous CL into two parts: scripts and the config. This is ...
3 years, 7 months ago (2017-05-26 08:04:44 UTC) #4
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-03 01:17:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904073003/130001
3 years, 6 months ago (2017-06-05 17:36:27 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 19:35:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #7 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/f7d9e91e64165b26cbfd95d29c33...

Powered by Google App Engine
This is Rietveld 408576698