Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 2910883002: Clean up duplicate tests in web-animations-api (Closed)

Created:
3 years, 6 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 6 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up duplicate tests in web-animations-api Most of the tests in the LayoutTests/web-animations-api directory have been upstreamed to the Web Platform Tests and are now redundant with tests in external/wpt/web-animations. This patch deletes the redundant test files. Test files that were added after the push to prepare the tests for upstreaming, or that were not upstreamed due to a need for further changes, have been moved to LayoutTests/animations to simplify the test directory structure. Some additional references to no-longer-existing tests in the web-animations-api directory have been removed from FlagExpectations and SmokeTests. The virtual/stable/web-animations-api tests have not been touched. BUG=623437, 591099 Review-Url: https://codereview.chromium.org/2910883002 Cr-Commit-Position: refs/heads/master@{#477224} Committed: https://chromium.googlesource.com/chromium/src/+/c8516e444e4348c99158fa53ea43f73c8a799d29

Patch Set 1 #

Patch Set 2 : Rebase and remove one more reference to deleted test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-7 lines, -2713 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/SmokeTests View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animation-cancel-in-raf.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animation-finish-in-raf.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animation-finish-promise-gc.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animation-ready-reject-script-forbidden.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animation-state-changes-negative-playback-rate.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animation-state-changes-positive-playback-rate.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/the-effect-value-of-a-keyframe-effect.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-in-raf.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-ready-finished-ordering.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-effect-read-only.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-effect-read-only-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-defaults.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-finish-in-raf.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-finish-promise-gc.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-finish-ready-finished-ordering.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-play-after-finish-restarts.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-ready-promise.html View 1 chunk +0 lines, -93 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-ready-promise-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-ready-reject-script-forbidden.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-reverse-end-exclusive.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-set-timeline.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-set-timeline-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html View 1 chunk +0 lines, -358 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animation-update-effect.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/effect-of-keyframeeffect-on-getComputedTiming.html View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/element-animate-list-of-keyframes.html View 1 chunk +0 lines, -289 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/element-animate-null-effect.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/fill-forward-negative-end-delay.html View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/keyframe-effect-iterable-keyframes.html View 1 chunk +0 lines, -122 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/keyframe-effect-iterable-keyframes-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/playState-changes.html View 1 chunk +0 lines, -384 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/reject-hyphen.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/startTime.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/startTime-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/the-effect-value-of-a-keyframe-effect.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/timeline-time.html View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/w3c/2-keyframes-with-offsets.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/w3c/3-keyframes-with-offsets.html View 1 chunk +0 lines, -146 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/w3c/get-animations.html View 1 chunk +0 lines, -90 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/w3c/get-animations-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/w3c/keyframe-properties.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/w3c/keyframes-with-null-offsets.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/w3c/resources/keyframes-test.js View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/w3c/simple-keyframes.html View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
suzyh_UTC10 (ex-contributor)
Hi Alan, I used our upstreaming spreadsheet https://docs.google.com/spreadsheets/d/14xRMeyf6KujO0HCacnFhaKAU_RMx2lSY65Z5ehalWHM/edit#gid=0 to cross-check the test deletions, but have ...
3 years, 6 months ago (2017-05-29 01:58:48 UTC) #2
alancutter (OOO until 2018)
On 2017/05/29 at 01:58:48, suzyh wrote: > Hi Alan, > > I used our upstreaming ...
3 years, 6 months ago (2017-06-06 00:15:33 UTC) #7
suzyh_UTC10 (ex-contributor)
On 2017/06/06 at 00:15:33, alancutter wrote: > On 2017/05/29 at 01:58:48, suzyh wrote: > > ...
3 years, 6 months ago (2017-06-06 01:30:58 UTC) #8
alancutter (OOO until 2018)
lgtm
3 years, 6 months ago (2017-06-06 05:34:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910883002/1
3 years, 6 months ago (2017-06-06 05:39:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/225925) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-06 05:41:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910883002/20001
3 years, 6 months ago (2017-06-06 05:47:54 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 07:10:50 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c8516e444e4348c99158fa53ea43...

Powered by Google App Engine
This is Rietveld 408576698