Use ui::PAGE_TRANSITION_RELOAD transition for web page reload.

Use ui::PAGE_TRANSITION_RELOAD transition for web page reload.

This will allow replacing -[CRWWebDelegate webWillReload] with
DidStartNavigation, because correct PageTransition will be passed to
DidStartNavigation callback.

BUG=725985
Review-Url: https://codereview.chromium.org/2910453002
Cr-Commit-Position: refs/heads/master@{#475143}
Committed: https://chromium.googlesource.com/chromium/src/+/b23d2a4dca1f06ef6d935b2612c2d050fc408338

[Eugene But (OOO till 7-30), 2017-05-25 16:30:15]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 16:30:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 16:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 16:44:48]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-25 17:10:08]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[Eugene But (OOO till 7-30), 2017-05-25 17:10:08]

https://codereview.chromium.org/2910453002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (left):

https://codereview.chromium.org/2910453002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2056: // using the web view's reload.
This ensures state processing and delegate
This is not true for WKWebView. |loadCurrentURL| will eventually call
-[WKWebView reload]

[Eugene But (OOO till 7-30), 2017-05-26 17:26:08]

Kurt?

[kkhorimoto, 2017-05-26 17:32:42]

https://codereview.chromium.org/2910453002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2910453002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2056:
ui::PageTransition::PAGE_TRANSITION_RELOAD);
Is this what's done in content// as well?  It seems weird that we love the
previous page transition type upon reloading.  I checked, and it looks like
RELOAD is not a bitwise enum, so we can't combine with the previous value, but
do they actually reset the NavigationEntry's transition type, or do they just
pass the RELOAD type around to interested functions?

[Eugene But (OOO till 7-30), 2017-05-26 17:48:33]

https://codereview.chromium.org/2910453002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2910453002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2056:
ui::PageTransition::PAGE_TRANSITION_RELOAD);
On 2017/05/26 17:32:42, kkhorimoto_ wrote:
> Is this what's done in content// as well?  It seems weird that we love the
> previous page transition type upon reloading.  I checked, and it looks like
> RELOAD is not a bitwise enum, so we can't combine with the previous value, but
> do they actually reset the NavigationEntry's transition type, or do they just
> pass the RELOAD type around to interested functions?
I'm pretty sure they reset navigation to reload which makes total sense to me:
https://cs.chromium.org/chromium/src/content/browser/frame_host/navigation_co...

[kkhorimoto, 2017-05-26 21:03:36]

lgtm

[Eugene But (OOO till 7-30), 2017-05-26 21:05:43]

Thanks!

[Eugene But (OOO till 7-30), 2017-05-26 21:05:49]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-05-26 21:06:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 21:43:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495832749050020, "parent_rev":
"1cf6fdc6f613fc2b4bae55dcb83f982a8531915b", "commit_rev":
"b23d2a4dca1f06ef6d935b2612c2d050fc408338"}

[commit-bot: I haz the power, 2017-05-26 21:44:06]

Description was changed from

==========
Use ui::PAGE_TRANSITION_RELOAD transition for web page reload.

This will allow replacing -[CRWWebDelegate webWillReload] with
DidStartNavigation, because correct PageTransition will be passed to
DidStartNavigation callback.

BUG=725985
==========

to

==========
Use ui::PAGE_TRANSITION_RELOAD transition for web page reload.

This will allow replacing -[CRWWebDelegate webWillReload] with
DidStartNavigation, because correct PageTransition will be passed to
DidStartNavigation callback.

BUG=725985

Review-Url: https://codereview.chromium.org/2910453002
Cr-Commit-Position: refs/heads/master@{#475143}
Committed:
https://chromium.googlesource.com/chromium/src/+/b23d2a4dca1f06ef6d935b2612c2...
==========

[commit-bot: I haz the power, 2017-05-26 21:44:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b23d2a4dca1f06ef6d935b2612c2...