Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2903173003: Removed -[CRWWebDelegate webWillReload] callback. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed -[CRWWebDelegate webWillReload] callback. Replaced with WebStateObserver::DidStartNavigation where Tab checks context's transition type to filter reloads. BUG=725985 Review-Url: https://codereview.chromium.org/2903173003 Cr-Commit-Position: refs/heads/master@{#475570} Committed: https://chromium.googlesource.com/chromium/src/+/72efed69faa7e40480308c569ebcbc90250007d4

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 2 chunks +6 lines, -5 lines 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Eugene But (OOO till 7-30)
Not time sensitive, can wait until marq@ is back.
3 years, 7 months ago (2017-05-25 20:59:26 UTC) #6
kkhorimoto
lgtm
3 years, 7 months ago (2017-05-25 21:08:34 UTC) #7
rohitrao (ping after 24h)
lgtm
3 years, 7 months ago (2017-05-26 12:45:12 UTC) #8
marq (ping after 24h)
lgtm
3 years, 6 months ago (2017-05-29 09:57:07 UTC) #9
Eugene But (OOO till 7-30)
Thanks everyone!
3 years, 6 months ago (2017-05-30 14:28:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903173003/1
3 years, 6 months ago (2017-05-30 14:29:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/226157)
3 years, 6 months ago (2017-05-30 15:37:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903173003/20001
3 years, 6 months ago (2017-05-30 16:44:47 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 17:00:17 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/72efed69faa7e40480308c569ebc...

Powered by Google App Engine
This is Rietveld 408576698